Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
Date:   Thu, 27 Sep 2018 15:14:03 +0200
From:   Rolf Eike Beer <eike-kernel@sf-tec.de>
To:     Leonardo Bras <leobras.c@gmail.com>
Cc:     linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 6/7] drivers: oprofile: Avoids building driver from
 direct make command
In-Reply-To: <CADvQ+rFPiaGKLyzfSx4DmTnmgG15=Jk0RVy8xuYYyvLPJfDdkA@mail.gmail.com>
References: <20180927014138.GA8988@WindFlash>
 <5236278.7dVKUIXYaR@daneel.sf-tec.de>
 <CADvQ+rFPiaGKLyzfSx4DmTnmgG15=Jk0RVy8xuYYyvLPJfDdkA@mail.gmail.com>
Message-ID: <136913b41707c8556fb5d41969d2080e@sf-tec.de>
User-Agent: Roundcube Webmail/1.3.6
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Am 2018-09-27 13:23, schrieb Leonardo Bras:
> Hello Rolf,
> 
> On Thu, Sep 27, 2018 at 3:34 AM, Rolf Eike Beer <eike-kernel@sf-tec.de> 
> wrote:
>> Am Donnerstag, 27. September 2018, 03:41:38 CEST schrieb Leonardo 
>> Brás:
>>> Creates new Makefile to avoid building driver if
>>> 'make drivers/oprofile/' is called directly.
>>> 
>>> This driver is usually built from arch/$ARCH and seems to have
>>> no meaning building alone.
>>> 
>>> Signed-off-by: Leonardo Brás <leobras.c@gmail.com>
>>> ---
>>>  drivers/oprofile/Makefile | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>  create mode 100644 drivers/oprofile/Makefile
>>> 
>>> diff --git a/drivers/oprofile/Makefile b/drivers/oprofile/Makefile
>>> new file mode 100644
>>> index 000000000000..acaed2ad6eee
>>> --- /dev/null
>>> +++ b/drivers/oprofile/Makefile
>>> @@ -0,0 +1,2 @@
>>> +#Does nothing, since the source is called from arch/$ARCH/ tree.
>>> +
>> 
>> Now there is a blank line where it does not need to be.
>> 
>> Eike
> 
> Oh, it's a Makefile, and as all text files, it have to end with 
> newline.
> If I am wrong, please let me know.

No, that's fine. But it means it has to have one LF after "tree.". It 
had none, now it hat 2.

Eike