Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 4.18 74/88] drm/atomic: Use drm_drv_uses_atomic_modeset()
 for debugfs creation
To:     Sean Paul <sean@poorly.run>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Lyude Paul <lyude@redhat.com>,
        Daniel Vetter <daniel.vetter@ffwll.ch>,
        Sean Paul <seanpaul@chromium.org>
References: <20180927090300.631426620@linuxfoundation.org>
 <20180927090309.614592493@linuxfoundation.org>
 <42cbbf9c-3076-0c49-36c2-b6fd09628694@applied-asynchrony.com>
 <20180927123706.GA23563@kroah.com>
 <f54355c2-4eeb-9b7a-3964-57ca465dae17@applied-asynchrony.com>
 <c3afb9a2-1cd6-b5b9-83ac-eed92fbc066e@applied-asynchrony.com>
 <20180927140527.GV72545@art_vandelay>
From:   =?UTF-8?Q?Holger_Hoffst=c3=a4tte?= <holger@applied-asynchrony.com>
Organization: Applied Asynchrony, Inc.
Message-ID: <0614233b-8934-336b-d509-90973cd8d69c@applied-asynchrony.com>
Date:   Thu, 27 Sep 2018 16:18:26 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20180927140527.GV72545@art_vandelay>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 09/27/18 16:05, Sean Paul wrote:
> On Thu, Sep 27, 2018 at 03:53:26PM +0200, Holger Hoffstätte wrote:
>> On 09/27/18 15:26, Holger Hoffstätte wrote:
>>> On 09/27/18 14:37, Greg Kroah-Hartman wrote:
>>>> On Thu, Sep 27, 2018 at 12:43:33PM +0200, Holger Hoffstätte wrote:
>>>>> On 09/27/18 11:03, Greg Kroah-Hartman wrote:
>>>>>> 4.18-stable review patch.  If anyone has any objections, please let me know.
>>>>>>
>>>>>> ------------------
>>>>>>
>>>>>> From: Lyude Paul <lyude@redhat.com>
>>>>>>
>>>>>> commit 3c499ea0c662e2f38aafbd4f516b08aab8cfa0e5 upstream.
>>>>>>
>>>>>> As pointed out by Daniel Vetter, we should be usinng
>>>>>> drm_drv_uses_atomic_modeset() for determining whether or not we want to
>>>>>> make the debugfs nodes for atomic instead of checking DRIVER_ATOMIC, as
>>>>>> the former isn't an accurate representation of whether or not the driver
>>>>>> is actually using atomic modesetting internally (even though it might
>>>>>> not be exposing atomic capabilities).
>>>>>>
>>>>>> Signed-off-by: Lyude Paul <lyude@redhat.com>
>>>>>> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
>>>>>> Cc: stable@vger.kernel.org
>>>>>> Reviewed-by: Sean Paul <seanpaul@chromium.org>
>>>>>> Link: https://patchwork.freedesktop.org/patch/msgid/20180917173733.21293-1-lyude@redhat.com
>>>>>> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>>>>>
>>>>> This patch breaks switching the console to high resolution during boot on my
>>>>> workstation with a Radeon card; it worked fine with 4.18.10 and reverting it
>>>>> fixes the problem:
>>>>
>>>> Is 4.19-rc5 also a problem?
>>>>
>>>
>>> No, 4.19-rc5 with the same config works fine and properly switches the
>>> console during boot.
>>>
>>> Interestingly another machine with i915 chip seemed to work fine with this
>>> patch included (rebooted that one first), so it might well be related to
>>> different motherboard/chipset or the Radeon card (an admittedly old, but
>>> otherwise completely functional fanless r600).
>>>
>>> I'll try to find more clues, but for now that's all I got.
>>
>> Looking at mainline include/drm I see several recent movements and cleanups
>> related to drm_drv_uses_atomic_modeset(), moving it out of drmP.h and into
>> drm, changes to atomic modesetting and such, all part of the 4.19 merge
>> window. I'm reasonably sure some relatred changes went missing here wrt.
>> this patch.
> 
> Hey all,
> Thanks for testing, Holger.
> 
> This was fixed with https://patchwork.freedesktop.org/patch/250350/ which is not
> Cc stable.

That's what I just looked at, it's in mainline as well. I briefly considered
backporting that fix manually, but was not sure why radeon is apparently not
a "modesetting driver" and figured I'd rather wait for someone who understands
drm better than me.

> I think it'd be best to just drop the initial patch from stable, it
> doesn't need to go back afaict.

Agreed - using 4.18.11 just fine right now without it. :)

cheers,
Holger