Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2129545imm; Thu, 27 Sep 2018 07:53:30 -0700 (PDT) X-Google-Smtp-Source: ACcGV613SFILkmWeTVhMlE82h61gUDUx7M8RUi1mRBjcBFWR4E0KR4SQJSJXmi1LMjB/UnMb++S9 X-Received: by 2002:a62:174a:: with SMTP id 71-v6mr12022141pfx.217.1538060010794; Thu, 27 Sep 2018 07:53:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538060010; cv=none; d=google.com; s=arc-20160816; b=gjxy1hd8h1oYZ9VfWtx98V2syhO2/CcCdK6D0rdEByFUZRIizV4wSWLkLvdC7kcIAe VPWDnG0kLRX79CWn24vikWkzskMOWl7n5leTvYPAHFjwPfQKj0AS8jaa+SoFU7yoApS9 qxfX/sagYAjlTSpFb+Lr5ogfATfN40euWspkVS4gEII8gYJAUAJXGSwrmNQ9fe89zCa4 KA9+Zk0LP5i3dVUgF1pZgB7ivtbSH61IFrrGN1Zp19Ca6XtdMfwTM/bsluOGDbZ+LwPO vL0MY7GFtKo1CMg/L9tlePJBxs7BjvCRihuBTCd5W+r11OJDaWlXgRBqVfx2wYgSGkWp fbZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=aJNLMFwBze8BjzatRalTyUCkgTVR65UT3VbDtpMy8n0=; b=XqS9tB6Zrea/HC4tRDwkkk/7anJnld/52wnTynkyrt8FOx83HRiMpY0P3453Je6uAN Uxjlm2eTOlfEegvTi0fQRjL0y9W3fZU9/YHAok0OHEOMUExOXjB145WOFg0Bgprt0SoM DkeXksnau2YiKfj7FOlKy4ku1d3H9jdNK5cSEI8CAe1/x67eiht9iYv9L9chZzkpFI4G KI/NfMMBjxnrpaMTjsTbA64CoK/H3TbHbb5O1qjBk11/xFw5Y7GzGqbTrifoomV2onDA HCZ9nxb0EmVR++Eolk7gBvFbNOW12Z8HkTT69j9x2YnjDuu0w2KlRPCA564THXiQQPDR TpJA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v10-v6si2191372pgg.216.2018.09.27.07.53.14; Thu, 27 Sep 2018 07:53:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728045AbeI0VL0 (ORCPT + 99 others); Thu, 27 Sep 2018 17:11:26 -0400 Received: from mga09.intel.com ([134.134.136.24]:23697 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727338AbeI0VLZ (ORCPT ); Thu, 27 Sep 2018 17:11:25 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Sep 2018 07:52:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,311,1534834800"; d="scan'208";a="87151763" Received: from jsakkine-mobl1.tm.intel.com (HELO localhost) ([10.237.50.69]) by orsmga003.jf.intel.com with ESMTP; 27 Sep 2018 07:52:39 -0700 Date: Thu, 27 Sep 2018 17:52:38 +0300 From: Jarkko Sakkinen To: Borislav Petkov Cc: x86@kernel.org, platform-driver-x86@vger.kernel.org, dave.hansen@intel.com, sean.j.christopherson@intel.com, nhorman@redhat.com, npmccallum@redhat.com, serge.ayoun@intel.com, shay.katz-zamir@intel.com, linux-sgx@vger.kernel.org, andriy.shevchenko@linux.intel.com, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Konrad Rzeszutek Wilk , David Woodhouse , David Wang , "Kirill A. Shutemov" , "Levin, Alexander (Sasha Levin)" , Jia Zhang , "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , He Chen , Luwei Kang , kvm@vger.kernel.org, Radim =?utf-8?B?S3LEjW3DocWZ?= , Piotr Luc , Paolo Bonzini Subject: Re: [PATCH v14 04/19] x86/cpufeatures: Add SGX feature bits Message-ID: <20180927145238.GA9769@linux.intel.com> References: <20180925130845.9962-1-jarkko.sakkinen@linux.intel.com> <20180925130845.9962-5-jarkko.sakkinen@linux.intel.com> <20180925164854.GF23986@zn.tnic> <20180926111139.GA12037@linux.intel.com> <20180926113617.GD5584@zn.tnic> <20180927131642.GE5436@linux.intel.com> <20180927135139.GB19687@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180927135139.GB19687@zn.tnic> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 27, 2018 at 03:51:39PM +0200, Borislav Petkov wrote: > On Thu, Sep 27, 2018 at 04:16:42PM +0300, Jarkko Sakkinen wrote: > > Still kind of leaves me puzzled about the situation :-) Why this wasn't > > used for example to replace detect_vmx_virtcap()? > > I don't understand - detect_vmx_virtcap() is setting X86_FEATURE bits > based on MSR settings. get_scattered_cpuid_leaf() is regenerating a > CPUID leaf from the scattered bits. > > Looks like apples and oranges to me... > > -- > Regards/Gruss, > Boris. > > Good mailing practices for 400: avoid top-posting and trim the reply. Ugh, sorry, I was not thinking clearly :-) /Jarkko