Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2144580imm; Thu, 27 Sep 2018 08:06:35 -0700 (PDT) X-Google-Smtp-Source: ACcGV63FtfSQPFj7iQvMIFT83deGBOSms764NKubSAl2D5+bGJ81C+HuAyOMELcbrLzQWvdknqpz X-Received: by 2002:a17:902:8687:: with SMTP id g7-v6mr4062606plo.30.1538060795676; Thu, 27 Sep 2018 08:06:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538060795; cv=none; d=google.com; s=arc-20160816; b=RltZeUDTII0PnxbY5W4dWGa+SFXz1JM52ir/3cP8OnofROsSTZMCDEomqMOl95bTh8 /s+ZBcy0dhTAXxNTpHDmVUUGxWFz2yVBv7KbL9XjRrIkdWdlQ8JjGRRLClbvemMq8dry teKJ7Bxlz88po1vmdZARL0XYIG2KZmemPN6mdCaVGZiS8HstTnU0iF2694Z/k4fzIN0T JN9QKsjSC1EaUKTaUGc51Avc7EKHMc8i0izMnuW53tP9kIv35xzUhbPo6w5a/EYeyAU9 vmAV+r1eBjiDBP4bFq6M79V9JBBtDpxsabjzS942OONXaHudljK3yacTEywWPH/dQnqn LvUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:message-id:date:subject:cc:from :dkim-signature; bh=VVGZLwXeE0i1LIHH1gUNgYMOYwc94MYsfYS79VjlR3E=; b=jxPfwOKGoYW25nDFzlAWLKKBhxMMbkXPE/7FqtZ9xlXSnxD38nKryLeWmEJmSHZDhA bLAh0u07ClfQWDbFygVdTFv8Gk7RBbdm3yP8g/ptoGuQoZhmqWbSeW5+/GB30+Cgi5Fj QiSKimm4ASkKspfYK8yDtXlQXbtxAu7x3ofrX5gLqOHeX33OnkwxTiqnpZ9L9EP9R41t LD5BFoWuBFhL7bH6r1n6Rnc+NT54rVvtcWFBEotaDXIHw1UJ2EZO05IcrnAgDjqcdUHH d2eETP5TWTwAQfDLWmCJucZdAl7jVugvGszy6TesH77q98WDzPzYAcX7EPAQ6s9V0ga6 jwBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=eRLULhc2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k6-v6si2340194pls.174.2018.09.27.08.06.14; Thu, 27 Sep 2018 08:06:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=eRLULhc2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727987AbeI0VYj (ORCPT + 99 others); Thu, 27 Sep 2018 17:24:39 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:35761 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727270AbeI0VYj (ORCPT ); Thu, 27 Sep 2018 17:24:39 -0400 Received: by mail-wm1-f66.google.com with SMTP id o18-v6so6353138wmc.0 for ; Thu, 27 Sep 2018 08:05:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=VVGZLwXeE0i1LIHH1gUNgYMOYwc94MYsfYS79VjlR3E=; b=eRLULhc2+lkMmlXO4nU3VENn5xoEGZVFL6PgpPEMxJ2Id/vgcpNSRtuFqg2bQbM4Hz 6Enq3OlgmLTCDLo5Lutdk0xWVFLqaVDHt8ScRTiJ9W6FTLNO55GW9h89UjpP4maI7l8U CYOJNMkA7QmPYRgw1yFA+QvkpV1Ns94vnXzqVA+joOSTVQW6Dz1tRKmDHAZHAsuvdV/3 2rqy1YqO3yOc/nleB/o2TrCL3fIeCU/wh3UDYdki12hVoJFp8MSO/mXbmDU5FdLN8VFX dypvu+vUD/DK4mSIDKf9uBMhJKxExSRXz8GpPZta3ENAVwLbJdWwsPzxQN2IHpOwsMMi VHnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=VVGZLwXeE0i1LIHH1gUNgYMOYwc94MYsfYS79VjlR3E=; b=TS45GG9gLcyqKunJcM9zzgslSo6C3NI+kP8nk9klU47JXD+Ru/IANdq300Td4fsmfg aeDIbdluOu5DMnlizB+Tl9Q6VQxja9rOnwBC/yVZotAS6WNeh+KDY9AyNu16CpMTTAqo fJqQd3QRxrV4vv3D7zW3LHz+MQxkdY+sJWZu8LwAf1OaSMpIIHk+cIR5WYK03eKTTZak LmSLdRCV3g2Ajpc3qz3iV/ZbfNjSsNnsHRHn0N0xgQa1dra6GwPFMAfDZk6+QjbQcNyo +5pgGDHjdzNM4FzHkMBIwfw1gmfjYysV28kG2CE5A6Qi4g3VjXAu++7WPxcGV1HoIdDV 3VUg== X-Gm-Message-State: ABuFfogX2CEliAD514qLLxQGKX5ZRQ7XKj0S+CyUM0t4cYafUzc/E+zZ AzFm1IEuJU3KZj/o2f1oBu2ky+I3Bsk= X-Received: by 2002:a1c:603:: with SMTP id 3-v6mr1127514wmg.64.1538060756215; Thu, 27 Sep 2018 08:05:56 -0700 (PDT) Received: from localhost.co.uk ([2a01:388:3ce:110::1:5]) by smtp.gmail.com with ESMTPSA id x65-v6sm2581658wmg.39.2018.09.27.08.05.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 27 Sep 2018 08:05:55 -0700 (PDT) From: Aymen Qader Cc: Wolfram Sang , Aymen Qader , Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] staging: ks7010: Add null pointer check for skb Date: Thu, 27 Sep 2018 16:05:44 +0100 Message-Id: <20180927150544.14632-1-qader.aymen@gmail.com> X-Mailer: git-send-email 2.17.1 To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add a null pointer check for the socket buffer in ks_hostif.c to avoid a possible null pointer deference. Signed-off-by: Aymen Qader --- drivers/staging/ks7010/ks_hostif.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c index 0e554e3359b5..4a5bc7858ef7 100644 --- a/drivers/staging/ks7010/ks_hostif.c +++ b/drivers/staging/ks7010/ks_hostif.c @@ -1011,6 +1011,11 @@ int hostif_data_request(struct ks_wlan_private *priv, struct sk_buff *skb) size_t size; int ret; + if(!skb) { + ret = -ENOMEM; + goto err_kfree; + } + skb_len = skb->len; if (skb_len > ETH_FRAME_LEN) { netdev_err(priv->net_dev, "bad length skb_len=%d\n", skb_len); -- 2.17.1