Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] Reduce boot header size with 1 byte
To:     xyproto@archlinux.org, linux-kernel@vger.kernel.org
References: <20180927134117.15371-1-xyproto@archlinux.org>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <52c315b1-e151-d728-9743-47e3189df8c9@infradead.org>
Date:   Thu, 27 Sep 2018 09:07:04 -0700
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:60.0) Gecko/20100101
 Thunderbird/60.0
MIME-Version: 1.0
In-Reply-To: <20180927134117.15371-1-xyproto@archlinux.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 9/27/18 6:41 AM, xyproto@archlinux.org wrote:
> From: Alexander F. Rødseth <xyproto@archlinux.org>
> 
> Only ah needs to be set to 0 before calling interrupt 0x16 for waiting
> for a keypress.
> 
> This patch changes the line that uses xor so that it only zeroes "ah" instead of "ax".
> This saves a byte.
> 
> Signed-off-by: Alexander F. Rødseth <xyproto@archlinux.org>

Hi,

You should Cc: the X86 maintainers on this patch.
Otherwise it will just be lost in the ether.

thanks.

> ---
>  arch/x86/boot/header.S | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/x86/boot/header.S b/arch/x86/boot/header.S
> index 850b8762e889..905cb96f43d4 100644
> --- a/arch/x86/boot/header.S
> +++ b/arch/x86/boot/header.S
> @@ -71,14 +71,15 @@ msg_loop:
>  	jmp	msg_loop
>  
>  bs_die:
> -	# Allow the user to press a key, then reboot
> -	xorw	%ax, %ax
> +	# Allow the user to press a key
> +	xorb	%ah, %ah
>  	int	$0x16
> +
> +	# Boostrap by reading sector 1, head 0, track 0 from drive
>  	int	$0x19
>  
> -	# int 0x19 should never return.  In case it does anyway,
> -	# invoke the BIOS reset code...
> -	ljmp	$0xf000,$0xfff0
> +	# If boostrap somehow did not work, invoke the BIOS reset code
> +	ljmp	$0xf000, $0xfff0
>  
>  #ifdef CONFIG_EFI_STUB
>  	.org	0x3c
> 


-- 
~Randy