Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 27 Sep 2018 22:39:01 +0200 (CEST)
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Reinette Chatre <reinette.chatre@intel.com>
cc:     Peter Zijlstra <peterz@infradead.org>, fenghua.yu@intel.com,
        tony.luck@intel.com, mingo@redhat.com, acme@kernel.org,
        gavin.hindman@intel.com, jithu.joseph@intel.com,
        dave.hansen@intel.com, hpa@zytor.com, x86@kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH V5 0/6] perf and x86/intel_rdt: Fix lack of coordination
 with perf
In-Reply-To: <77383a1e-f343-7529-24cf-874f0999507d@intel.com>
Message-ID: <alpine.DEB.2.21.1809272123440.8118@nanos.tec.linutronix.de>
References: <cover.1537377064.git.reinette.chatre@intel.com> <20180920141150.GY24124@hirez.programming.kicks-ass.net> <77383a1e-f343-7529-24cf-874f0999507d@intel.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 21 Sep 2018, Reinette Chatre wrote:

> Dear Maintainers,

Sorry for replying late.

> On 9/20/2018 7:11 AM, Peter Zijlstra wrote:
> > On Wed, Sep 19, 2018 at 10:29:05AM -0700, Reinette Chatre wrote:
> >> Reinette Chatre (6):
> >>   perf/core: Add sanity check to deal with pinned event failure
> >>   perf/x86: Add helper to obtain performance counter index
> >>   x86/intel_rdt: Remove local register variables
> >>   x86/intel_rdt: Create required perf event attributes
> >>   x86/intel_rdt: Use perf infrastructure for measurements
> >>   x86/intel_rdt: Re-enable pseudo-lock measurements
> >>
> >>  Documentation/x86/intel_rdt_ui.txt          |  22 +-
> >>  arch/x86/events/core.c                      |  21 ++
> >>  arch/x86/include/asm/perf_event.h           |   1 +
> >>  arch/x86/kernel/cpu/intel_rdt_pseudo_lock.c | 372 ++++++++++++--------
> >>  kernel/events/core.c                        |   6 +
> >>  5 files changed, 261 insertions(+), 161 deletions(-)
> > 
> > Yeah, these look good, thanks!
> > 
> > Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> > 
> 
> Could you please consider this series for inclusion into v4.19?

So in principle I'm having no objections as this really is mostly a RDT
only issue.

Peter, any objections against the Perf part of it, aside the core patch
which is an obvious fix?

Thanks,

	tglx