Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2506897imm; Thu, 27 Sep 2018 14:08:07 -0700 (PDT) X-Google-Smtp-Source: ACcGV60DFqQkXTvcRjQopgv/wZNQvbnJlRM2K7F6SG6VkZ3jkOU2Yo90RG671tAWDVugDXPdU4B8 X-Received: by 2002:a62:63c2:: with SMTP id x185-v6mr13243008pfb.13.1538082487460; Thu, 27 Sep 2018 14:08:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538082487; cv=none; d=google.com; s=arc-20160816; b=G3s1Gm0S7fMrYm9o3PJidek1Ez73tX4XQmcT8JtNs6WnfM8xZYWx/B8qilRQaHQdk2 LwjFf4Vn/DOofMhaIQZx+puJMb9dwe/WR+u37MX0D1r4opscwghb5Loi0UeHPDDi8zqb kiofreIF5I0NfkFtmEZjCEBhqX9Ro8Kgkl2uMr5NRUYwvCnr4jx5Rd0dI+fTx/jkDdQs QlaxacYSgsONisiYUAF1D4sYjvLFZn7PBiXGvrEa4bVs67LbxGiri/aMNq5CmRjypqUF K213L+xb1REyy4cX12imQg9GInVyPF1jdJJHo6otTMW7nSWPEEZPQ+AAd8vJd8A+ctjc ymBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=uv0TeId7IdMxNEmopP0UrwlEvsX7ixnl1dD7ytjd/e4=; b=GgfNL9nzO7U4CI7XeOekDjQ58kY5BHDp2u8oEDCsY8yHEp8RcQyvuOaKpVivTf1pCo c7iE7iWGhjxRe953FE6JJSQNOSOegCdc9cBTYkSEy3k4/XPUNOc3ZR4PvdVuvM0bib1C xKLy1PfZasaDyLJ/36qStg/ytV4lgJvk1N9HgPiF1YPQZ8Lji24yFm8JpUP+gzEodWPP 38/0ONzLJSMWIagfvxjMzERvQavdljVvQKKyh+ARpAL+vPbA0gWLPr9Ez0yhMEkfaQ0c iDCyxZ+8EnuxmNguXV4xQitFINySxM5or1Ren6QeFa5oscjNTQZp6DRTTRhXo5wJjmi3 J/wQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=tOcAeLK0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e9-v6si2917471pgj.70.2018.09.27.14.07.48; Thu, 27 Sep 2018 14:08:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=tOcAeLK0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727486AbeI1D1h (ORCPT + 99 others); Thu, 27 Sep 2018 23:27:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:54310 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727265AbeI1D1h (ORCPT ); Thu, 27 Sep 2018 23:27:37 -0400 Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B937A216FA; Thu, 27 Sep 2018 21:07:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1538082444; bh=uv0TeId7IdMxNEmopP0UrwlEvsX7ixnl1dD7ytjd/e4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=tOcAeLK06Apv2NskWwBuoogPDCxvxdM9CCGPbIDnj0qWdl7uiIGcfdb1p/QukM8OL pdZWPQwm48PFkQoEp75ER+LOuJDJTADznhB5adFzdm3Oqamg4Pdn+uUn7fJIWFTAq9 WYTBf0L0DTcbBtlUUlwledlovbZv+IGmvtYp8254= Received: by mail-qt1-f170.google.com with SMTP id l2-v6so4349771qtr.12; Thu, 27 Sep 2018 14:07:24 -0700 (PDT) X-Gm-Message-State: ABuFfojaoELM1WmWVpRZSf1jMpwWI3Mr4jCVNekrVgsotJfSEd+9ikyN F8FVk297jXiGiSju+GM1Ev9CMIu616/YP2RKxA== X-Received: by 2002:ac8:46d3:: with SMTP id h19-v6mr10047216qto.188.1538082444020; Thu, 27 Sep 2018 14:07:24 -0700 (PDT) MIME-Version: 1.0 References: <1538067327-5785-1-git-send-email-maksym.kokhan@globallogic.com> In-Reply-To: <1538067327-5785-1-git-send-email-maksym.kokhan@globallogic.com> From: Rob Herring Date: Thu, 27 Sep 2018 16:07:12 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/8] drivers: of: ifdef out cmdline section To: maksym.kokhan@globallogic.com Cc: Frank Rowand , Daniel Walker , Daniel Walker , aborduno@cisco.com, rbilovol@cisco.com, devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 27, 2018 at 11:55 AM Maksym Kokhan wrote: > > From: Daniel Walker > > It looks like there's some seepage of cmdline stuff into > the generic device tree code. This conflicts with the > generic cmdline implementation so I remove it in the case > when that's enabled. What's preventing removing this or simplifying the DT code to just be "give me the cmdline data from DT" and the common code deals with all the combinations of config options. Rob