Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2] staging: rtl8188eu: Skip unnecessary field checks
To:     Aymen Qader <qader.aymen@gmail.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
References: <20180927211911.26484-1-qader.aymen@gmail.com>
From:   Larry Finger <Larry.Finger@lwfinger.net>
Message-ID: <ac8995c8-0dee-6f55-fdb7-a1cb9328d364@lwfinger.net>
Date:   Thu, 27 Sep 2018 17:04:14 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.0
MIME-Version: 1.0
In-Reply-To: <20180927211911.26484-1-qader.aymen@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 9/27/18 4:19 PM, Aymen Qader wrote:
> Skip unnecessary request field checks when the information element
> pointer is null.
> 
> Signed-off-by: Aymen Qader <qader.aymen@gmail.com>
> ---
> v2: combine pointer check and length check & change commit message to be
> more appropriate
> 
>   drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
> index 834053a0ae9d..4d55bbdf8fb7 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
> @@ -2971,11 +2971,11 @@ static unsigned int OnAssocReq(struct adapter *padapter,
>   	/*  checking SSID */
>   	p = rtw_get_ie(pframe + WLAN_HDR_A3_LEN + ie_offset, _SSID_IE_, &ie_len,
>   		pkt_len - WLAN_HDR_A3_LEN - ie_offset);
> -	if (!p)
> -		status = _STATS_FAILURE_;
>   
> -	if (ie_len == 0) { /*  broadcast ssid, however it is not allowed in assocreq */
> +	if (!p || ie_len == 0) {
> +		/*  broadcast ssid, however it is not allowed in assocreq */
>   		status = _STATS_FAILURE_;
> +		goto OnAssocReqFail;
>   	} else {
>   		/*  check if ssid match */
>   		if (memcmp((void *)(p+2), cur->Ssid.Ssid, cur->Ssid.SsidLength))
> 

ACKed-by: Larry Finger <Larry.Finger@lwfinger.net>