Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp305652imm; Thu, 27 Sep 2018 21:54:09 -0700 (PDT) X-Google-Smtp-Source: ACcGV61ZCrybNKRzDuXaB4jTpxZoaCl7SH/AZhMRV9k/FESbz1JX7l74wgYDqxpgi5v6qKDj+vhj X-Received: by 2002:aa7:8895:: with SMTP id l21-v6mr2413210pfo.74.1538110449637; Thu, 27 Sep 2018 21:54:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538110449; cv=none; d=google.com; s=arc-20160816; b=QI31N3t/FBSksaLrTY4XDjuqJ54G7ILAPv3HBTGOoDdoBhadX8YFr6o+pTRKxUewdv poPHg3jwv2Kb/3X1R8eaq1aG+uKYqWjMboAI4dwBlXqDKnFv1zoXo5v9INy7wnMuwDt/ xpF9kzSbSQEopm7J42bgtTtfyszMMRK5hidbFx01nF1yvnqAFoRW9d5ifVSGBgdkD0XA TaqQVO7pHd7zh98RsEl35RsstONW4HKDopZxjra5hA2NUJwRU0PL20QnzCgdrx9eOsHF v54ZfyXTxbrZk8MLsdA5vCFy6xSxl1czdBcEWl7uSL0dMBqY1gPgomS7eswRX6C5hnZS I0mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from; bh=VGbK3jKxmdORuXSNr4fAMPI2DTJu3XssLAiuk4yslC8=; b=pPi2iZAMXQJsm5X8OpVq4z6aY6fqY+03LhZxVoqPzbKxBC2MsFgufTJ7v2f5VaPMZ0 gCUZwYKgTXBR1S+JsRdl1MvezjFPXvE9bsbKZkaBuNmCUfUZ3xeaUtfXYteG/Rc/nsvs Spcm1W7cqSwiVed0a7B23/ZAkaOo542tmksTKqeVb5PH82YCi+TuYN2NCwznhE2ITKur dvLO4aIVkFV8JrWbJTfSc3oU+LYAumDuAoaymxK1yZagtqS71KsD0Yg6oQho9zk4bGFq Ixp2Bp9yUkPt5IonGBPAPVh6SU+mboe9Ux6CGWG/U70YFp8iVfyWBuDhcJCO+vAoFo8J gdZA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k24-v6si3767078pgj.28.2018.09.27.21.53.53; Thu, 27 Sep 2018 21:54:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728746AbeI1LOT (ORCPT + 99 others); Fri, 28 Sep 2018 07:14:19 -0400 Received: from ozlabs.org ([203.11.71.1]:56037 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726121AbeI1LOT (ORCPT ); Fri, 28 Sep 2018 07:14:19 -0400 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPSA id 42Lzn31BLwz9s3Z; Fri, 28 Sep 2018 14:52:22 +1000 (AEST) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au From: Michael Ellerman To: Anders Roxell , yamada.masahiro@socionext.com, michal.lkml@markovi.net, shuah@kernel.org, bamv2005@gmail.com, brgl@bgdev.pl, pbonzini@redhat.com, akpm@linux-foundation.org, rppt@linux.vnet.ibm.com, aarcange@redhat.com Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, netdev@vger.kernel.org, Anders Roxell , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v6] selftests: add headers_install to lib.mk In-Reply-To: <20180904104721.27535-1-anders.roxell@linaro.org> References: <20180809080402.24469-1-anders.roxell@linaro.org> <20180904104721.27535-1-anders.roxell@linaro.org> Date: Fri, 28 Sep 2018 14:52:22 +1000 Message-ID: <87y3bmte9l.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ + linuxppc-dev ] Anders Roxell writes: > If the kernel headers aren't installed we can't build all the tests. > Add a new make target rule 'khdr' in the file lib.mk to generate the > kernel headers and that gets include for every test-dir Makefile that > includes lib.mk If the testdir in turn have its own sub-dirs the > top_srcdir needs to be set to the linux-rootdir to be able to generate > the kernel headers. > > Signed-off-by: Anders Roxell > Reviewed-by: Fathi Boudra > --- > > I sent this (v5) a month ago and wondered if it got lost. Resending > unchanged. > > Cheers, > Anders > > Makefile | 14 +------------- > scripts/subarch.include | 13 +++++++++++++ > tools/testing/selftests/android/Makefile | 2 +- > tools/testing/selftests/android/ion/Makefile | 2 ++ > tools/testing/selftests/futex/functional/Makefile | 1 + > tools/testing/selftests/gpio/Makefile | 7 ++----- > tools/testing/selftests/kvm/Makefile | 7 ++----- > tools/testing/selftests/lib.mk | 12 ++++++++++++ > tools/testing/selftests/net/Makefile | 1 + > .../selftests/networking/timestamping/Makefile | 1 + > tools/testing/selftests/vm/Makefile | 4 ---- > 11 files changed, 36 insertions(+), 28 deletions(-) > create mode 100644 scripts/subarch.include This broke all the powerpc selftests :( Why did it go in at rc5? cheers