Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp318154imm; Thu, 27 Sep 2018 22:10:12 -0700 (PDT) X-Google-Smtp-Source: ACcGV63ip9jd20hs43O5oC3Qoic+2ySWAZYPUj9eI1DGE6GhSogNRxTdi0lL6rC7EofS3x0eOpBM X-Received: by 2002:a17:902:561:: with SMTP id 88-v6mr14148961plf.320.1538111412061; Thu, 27 Sep 2018 22:10:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538111412; cv=none; d=google.com; s=arc-20160816; b=IDljJ7Fb2vAjLHjocGguz35q89rm+m8XZmbL7VtuR18gQPNYvoseHpbKYjl0Tf1seE 9gikS99C5jyPrcOwD283e+7XMbjkudJnk7MekwUi0KRUFuy3uizyQ7/e9lCNVmS2miMi dClJo2GPLAEF2kG+VbPbNsmfG5kFo0z3W5NowFjSnNvWRiqSjU/HJGg8CCUO+B+qI5Ni DbHeSz3jpkh8xStHHcv1LMANwtgm1Lr47rX4lcAAJXjV9caJ2kWZ6z1qnpJInGrC13Y4 bZjljjQh1x7G5dllDLfVweZMhZtuwC+H6p3KbmIbJRJaMBsx2mlwr0AcarxNMsQEZsFl welQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=QkTJD1qyS6sZ8ZRQtmukRcai+KZRmtdNCt9S0XGHVqo=; b=fKOzMaY5s3GJNw+pDUfnNvKQfwcBqZIacND8D/cWKWEPVO9a4GZ/9fTMVAJh8M8hZf Y+lvKfPODpBN8oOE8+wh6y4+YspZt7NaDLXFqCJ0aki63deXL/TF1+0ViKNmN9GJRgS5 7Mg7d9yXPWyd2JD5qkvm/czecLIHf3pjiQ7RrIb0MXNYMzAJ+6EmpCD9lrRF+YXRaKkS seWVhyiHQlD1k4dIQhfAW3ShPR58RqOWYAsMl3aVpTTtLlJ03xB9G3Exe7Lq2SzCK9NB NIKEKvqXmAzh8NT/1Jqo+7ELhggnYKmeRqpl8nSh7ijWvuukjfeEN/66mog9EM+05c6o be1w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m185-v6si4052351pgm.206.2018.09.27.22.09.55; Thu, 27 Sep 2018 22:10:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728818AbeI1LbW (ORCPT + 99 others); Fri, 28 Sep 2018 07:31:22 -0400 Received: from orcrist.hmeau.com ([104.223.48.154]:42564 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726060AbeI1LbW (ORCPT ); Fri, 28 Sep 2018 07:31:22 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1g5l1m-00006m-Mm; Fri, 28 Sep 2018 13:09:22 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1g5l1l-000610-8W; Fri, 28 Sep 2018 13:09:21 +0800 Date: Fri, 28 Sep 2018 13:09:21 +0800 From: Herbert Xu To: zhong jiang Cc: davem@davemloft.net, harsh@chelsio.com, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] crypto : chtls: remove redundant null pointer check before kfree_skb Message-ID: <20180928050921.m6eee4twxlp2oovt@gondor.apana.org.au> References: <1537437436-43088-1-git-send-email-zhongjiang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1537437436-43088-1-git-send-email-zhongjiang@huawei.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 20, 2018 at 05:57:16PM +0800, zhong jiang wrote: > kfree_skb has taken the null pointer into account. hence it is safe > to remove the redundant null pointer check before kfree_skb. > > Signed-off-by: zhong jiang Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt