Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp480805imm; Fri, 28 Sep 2018 01:35:50 -0700 (PDT) X-Google-Smtp-Source: ACcGV61e+R3lyZxMtScZemM9lbuPwf9VqIlk7LFb871h78D6Z8MZk4aulWragFCNZvRZSOTl4J7n X-Received: by 2002:a63:86c8:: with SMTP id x191-v6mr11116238pgd.39.1538123749926; Fri, 28 Sep 2018 01:35:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538123749; cv=none; d=google.com; s=arc-20160816; b=MVvzg3w12mNKcMDZ7Sc0SbbL0NPBMqyi3VEeDSIR2Kdb0y6NfENTTt3i+gy346zKhm wUtTsTPSHD9d6ub7Eq86fET6kNHZCXfT8wvMy5qKLraPYLP5IPj2eO9/dPQEHEA2w73b pAFxL4eDwOJpJu9SiMAb4Z3TvXFZAP7kah3BekbPi1tvazkWxYj7MG8gapZpmWU5gTaV flCWCKldHG2YI9ZJd4vAg47CsR7MJRHa753UVKfJRE7lPkBMJ12kHclBc6SzMqjyGTuW bpmHa1AvEwWdhGUQnZ7iwzl6CzlNjYLka76QGK1nkhka7iKm3cR4Bw6RhX+GaIWifbKl CPMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=NZ4Yqd/tzhh8XglP8zohnDMcACmfLTe8Luuj6fi9qDU=; b=eZchpFgXobL56IWamg89se3ghZkryCwoZ7jnJ1gAfnJlYv3/HZC+VTtVe8Sj9AYw57 0Ic3UF+eFzklQJLjNjPOqK9pC9F6kXp+94XyOmEouys26QWLePiJUH2r0C5eJQgJJVke bRq0thKHzCgVfTEMAYiFRUoUg4kle81FehDyJkb16qKz4BXpQqw7gxoyXqDybiBwGQTU J3Tamtco5WiYK816EZsKCqtK0YjuTpaUwxDFIQh2dcRL9u3ASO0pz38+68WMr1aUTOLC /ZITohnt42Gs+L9w70I9oKWF8wBkcQE+oetD500PYB1ox90ltFjhvt599RDIU6LYgVZ6 SSDA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h20-v6si4076489pgh.573.2018.09.28.01.35.33; Fri, 28 Sep 2018 01:35:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729000AbeI1O5u (ORCPT + 99 others); Fri, 28 Sep 2018 10:57:50 -0400 Received: from foss.arm.com ([217.140.101.70]:44742 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726586AbeI1O5u (ORCPT ); Fri, 28 Sep 2018 10:57:50 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B752C7A9; Fri, 28 Sep 2018 01:35:11 -0700 (PDT) Received: from queper01-lin (queper01-lin.emea.arm.com [10.4.13.27]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 753B03F5D3; Fri, 28 Sep 2018 01:35:07 -0700 (PDT) Date: Fri, 28 Sep 2018 09:35:05 +0100 From: Quentin Perret To: "Rafael J. Wysocki" Cc: "Rafael J. Wysocki" , Peter Zijlstra , Linux Kernel Mailing List , Linux PM , Greg Kroah-Hartman , Ingo Molnar , Dietmar Eggemann , Morten Rasmussen , Chris Redpath , Patrick Bellasi , Valentin Schneider , Vincent Guittot , Thara Gopinath , Viresh Kumar , Todd Kjos , Joel Fernandes , Steve Muckle , adharmap@codeaurora.org, Saravana Kannan , Pavan Kondeti , Juri Lelli , Eduardo Valentin , Srinivas Pandruvada , currojerez@riseup.net, Javi Merino Subject: Re: [PATCH v7 02/14] sched/cpufreq: Prepare schedutil for Energy Aware Scheduling Message-ID: <20180928083503.h4jbdgk3dqpaufzb@queper01-lin> References: <20180912091309.7551-1-quentin.perret@arm.com> <20180927121749.urdqtayq6ll4k7qn@queper01-lin> <2417577.QmA9JEQx1z@aspire.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2417577.QmA9JEQx1z@aspire.rjw.lan> User-Agent: NeoMutt/20171215 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rafael, On Friday 28 Sep 2018 at 10:23:42 (+0200), Rafael J. Wysocki wrote: [...] > OK, so please document the enum type. Will do. [...] > Documenting things properly is absolutely required. Understood. > The other changes suggested by me are rather straightforward, so why would it > be a problem to make them right away if you agree to make them? Right, if I need to spin a v8 for doc purpose anyway, I guess I can do the other small fixes at the same time. I'll wait a bit before sending the update to see if others have some feedback. It's probably a bit late for 4.20 anyway ... Or is it not ? Thanks, Quentin