Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v3 2/2] vfio: add edid support to mbochs sample driver
To:     Gerd Hoffmann <kraxel@redhat.com>
CC:     <intel-gvt-dev@lists.freedesktop.org>,
        Alex Williamson <alex.williamson@redhat.com>,
        <kvm@vger.kernel.org>, open list <linux-kernel@vger.kernel.org>
References: <20180921083013.15028-1-kraxel@redhat.com>
 <20180921083013.15028-3-kraxel@redhat.com>
 <4b9847dd-c37d-1d5d-3343-7030e62894fb@nvidia.com>
 <20180928054056.vjqwxvaj7sjmsozh@sirius.home.kraxel.org>
From:   Kirti Wankhede <kwankhede@nvidia.com>
Message-ID: <646427f9-7bed-43aa-6aba-9b5e82eecb68@nvidia.com>
Date:   Fri, 28 Sep 2018 14:10:26 +0530
MIME-Version: 1.0
In-Reply-To: <20180928054056.vjqwxvaj7sjmsozh@sirius.home.kraxel.org>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 9/28/2018 11:10 AM, Gerd Hoffmann wrote:
>>> +	case MBOCHS_EDID_REGION_INDEX:
>>> +		ext->base.argsz = sizeof(*ext);
>>> +		ext->base.offset = MBOCHS_EDID_OFFSET;
>>> +		ext->base.size = MBOCHS_EDID_SIZE;
>>> +		ext->base.flags = (VFIO_REGION_INFO_FLAG_READ  |
>>> +				   VFIO_REGION_INFO_FLAG_WRITE |
>>> +				   VFIO_REGION_INFO_FLAG_CAPS);
>>
>> Any reason to not to use _MMAP flag?
> 
> There is no page backing this.  Also it is not performance-critical,
> edid updates should be rare, so the extra code for mmap support doesn't
> look like it is worth it.
> 
> Also for the virtual registers (especially link_state) it is probably
> useful to have the write callback of the mdev driver called to get
> notified about the change.
> 
>> How would QEMU side code read this region? will it be always trapped?
> 
> qemu uses read & write syscalls (well, pread & pwrite actually).
> 
>> If vendor driver sets _MMAP flag, will QEMU side handle that case as well?
> 
> The current test branch doesn't, it expects read+write to work.
>   https://git.kraxel.org/cgit/qemu/log/?h=sirius/edid-vfio
> 

Ok.
Can you add a comment in vfio.h that this region is non-mmappable?

>> I think since its blob, edid could be read by QEMU using one memcpy
>> rather than adding multiple memcpy of 4 or 8 bytes.
> 
> From qemu it's a single pwrite syscall actually.  mbochs_write() splits
> it into 4 byte writes and calls mbochs_access() for each of them.  One
> could probably add a special case for the EDID blob to mbochs_write().
> But again: doesn't seem worth the effort given that edid updates should
> be a rare event.
> 

Ok.

Thanks,
Kirti

> cheers,
>   Gerd
>