Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [RFC 3/5] perf: Allow per PMU access control
To:     Andi Kleen <ak@linux.intel.com>,
        Tvrtko Ursulin <tursulin@ursulin.net>
Cc:     linux-kernel@vger.kernel.org,
        Tvrtko Ursulin <tvrtko.ursulin@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Madhavan Srinivasan <maddy@linux.vnet.ibm.com>,
        Alexey Budankov <alexey.budankov@linux.intel.com>,
        x86@kernel.org
References: <20180919122751.12439-1-tvrtko.ursulin@linux.intel.com>
 <20180919122751.12439-4-tvrtko.ursulin@linux.intel.com>
 <20180927201559.GH28040@tassilo.jf.intel.com>
From:   Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Message-ID: <38a45f2b-b47a-fccd-2c87-3a46502202a4@linux.intel.com>
Date:   Fri, 28 Sep 2018 09:57:37 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20180927201559.GH28040@tassilo.jf.intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 27/09/2018 21:15, Andi Kleen wrote:
>> +	mutex_lock(&pmus_lock);
>> +	list_for_each_entry(pmu, &pmus, entry)
>> +		pmu->perf_event_paranoid = sysctl_perf_event_paranoid;
>> +	mutex_unlock(&pmus_lock);
> 
> What happens to pmus that got added later?

There is a hunk a bit lower in the patch where in perf_pmu_register the 
initial setting is assigned from the global sysctl.

> The rest looks good.
> 
> Can you post a non RFC version?

Sure!

Regards,

Tvrtko