Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To:     Mihir Mehta <mihir@cs.utexas.edu>
Cc:     linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fat: Expand a slightly out-of-date comment
References: <20180927150046.11538-1-mihir@cs.utexas.edu>
Date:   Fri, 28 Sep 2018 19:32:43 +0900
In-Reply-To: <20180927150046.11538-1-mihir@cs.utexas.edu> (Mihir Mehta's
        message of "Thu, 27 Sep 2018 10:00:46 -0500")
Message-ID: <87sh1tewtw.fsf@mail.parknet.co.jp>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Mihir Mehta <mihir@cs.utexas.edu> writes:

> The file namei.c seems to have been renamed to namei_msdos.c, so I
> decided to update the comment with the correct name, and expand it a bit
> to tell the reader what to look for.
> ---
>  fs/fat/dir.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/fat/dir.c b/fs/fat/dir.c
> index b833ffe..d954e18 100644
> --- a/fs/fat/dir.c
> +++ b/fs/fat/dir.c
> @@ -368,7 +368,8 @@ static int fat_parse_short(struct super_block *sb,
>  	}
>  
>  	memcpy(work, de->name, sizeof(work));
> -	/* see namei.c, msdos_format_name */
> +	/* For an explanation of the special treatment of 0x05 in
> +	   filenames, see msdos_format_name in namei_msdos.c */
>  	if (work[0] == 0x05)
>  		work[0] = 0xE5;

Sorry. However, could you use

	/*
         *
         */

style comment? Otherwise, looks good.

Thanks.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>