Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] drivers: irqchip: pdc: setup all edge interrupts as
 rising edge at GIC
To:     Lina Iyer <ilina@codeaurora.org>, evgreen@chromium.org
Cc:     bjorn.andersson@linaro.org, rplsssn@codeaurora.org,
        linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        rnayak@codeaurora.org, andy.gross@linaro.org, sboyd@kernel.org,
        dianders@chromium.org
References: <20180927171810.22968-1-ilina@codeaurora.org>
From:   Marc Zyngier <marc.zyngier@arm.com>
Organization: ARM Ltd
Message-ID: <27d7df0d-4429-dcdd-f527-a33f9385b4e0@arm.com>
Date:   Fri, 28 Sep 2018 11:40:22 +0100
User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20180927171810.22968-1-ilina@codeaurora.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 27/09/18 18:18, Lina Iyer wrote:
> The PDC irqchp can convert a falling edge or level low interrupt to a
> rising edge or level high interrupt at the GIC. We just need to setup
> the GIC correctly. Set up the interrupt type for the IRQ_TYPE_EDGE_BOTH
> as IRQ_TYPE_EDGE_RISING at the GIC.
> 
> Reported-by: Evan Green <evgreen@chromium.org>
> Signed-off-by: Lina Iyer <ilina@codeaurora.org>
> ---
>   drivers/irqchip/qcom-pdc.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/irqchip/qcom-pdc.c b/drivers/irqchip/qcom-pdc.c
> index b1b47a40a278..faa7d61b9d6c 100644
> --- a/drivers/irqchip/qcom-pdc.c
> +++ b/drivers/irqchip/qcom-pdc.c
> @@ -124,6 +124,7 @@ static int qcom_pdc_gic_set_type(struct irq_data *d, unsigned int type)
>   		break;
>   	case IRQ_TYPE_EDGE_BOTH:
>   		pdc_type = PDC_EDGE_DUAL;
> +		type = IRQ_TYPE_EDGE_RISING;
>   		break;
>   	case IRQ_TYPE_LEVEL_HIGH:
>   		pdc_type = PDC_LEVEL_HIGH;
> 

Queued for 4.20, with

Fixes: f55c73aef890 ("irqchip/pdc: Add PDC interrupt controller for QCOM 
SoCs")

added. Please consider providing these tags in the future.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...