Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] PCI/AER: Clear uncorrectable error status for device
To:     poza@codeaurora.org, Bjorn Helgaas <helgaas@kernel.org>
Cc:     Bjorn Helgaas <bhelgaas@google.com>,
        Philippe Ombredanne <pombredanne@nexb.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Kate Stewart <kstewart@linuxfoundation.org>,
        linux-pci@vger.kernel.org, Keith Busch <keith.busch@intel.com>,
        Wei Zhang <wzhang@fb.com>, linux-kernel@vger.kernel.org,
        Giovanni Cabiddu <giovanni.cabiddu@intel.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S . Miller" <davem@davemloft.net>,
        Dan Williams <dan.j.williams@intel.com>,
        Kees Cook <keescook@chromium.org>,
        Sagi Grimberg <sagi@grimberg.me>,
        Adaptec OEM Raid Solutions <aacraid@microsemi.com>,
        "James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>
References: <1537258829-15763-1-git-send-email-poza@codeaurora.org>
 <20180926220848.GK28024@bhelgaas-glaptop.roam.corp.google.com>
 <605a3c5d65ae2f42237c7258a6c3e21b@codeaurora.org>
From:   Sinan Kaya <okaya@kernel.org>
Message-ID: <e7b35f31-c684-ddac-7393-435640c6af39@kernel.org>
Date:   Fri, 28 Sep 2018 09:58:27 -0400
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <605a3c5d65ae2f42237c7258a6c3e21b@codeaurora.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 9/28/2018 6:24 AM, poza@codeaurora.org wrote:
> 1) Does that seem like the right place?
> 

IMO, I think best is to call after driver callback in PCI core.
A driver specific action can cause some of these errors.
We don't want to return with outstanding errors.

> 2) I guess all we need now would be to remove the calls from the
>     drivers?
> 

yes

> 3) If we remove all the calls from the drivers, we should remove the
>     declaration from include/linux/aer.h, too.
> 

makes sense

> I can take care of these updates if we agree they're the right thing
> to do.