Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp813224imm; Fri, 28 Sep 2018 07:15:52 -0700 (PDT) X-Google-Smtp-Source: ACcGV60t2+cTCKjI3NYYaaw13QsTLwmO2t4EPDmUQngmd5jPfuV/p1jYqo1aqp1n+eiD7P+CL5Zi X-Received: by 2002:a62:7a81:: with SMTP id v123-v6mr13368594pfc.240.1538144152786; Fri, 28 Sep 2018 07:15:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538144152; cv=none; d=google.com; s=arc-20160816; b=bWBmshunaHAToe622LirrwjPkh1WgC364zQ5c615OS9CDxmhWVqfB70L7qpEfeD5nR SqCri97z2rT7ttmSBtGIWWst8pVbvq3s8Hft3/wtWfLSdubvc08aRAcxDzirN5VNqjxZ ulfIV0f25qq9t1HTeoWF+hNYlY5P0x4+valC2M24gRKjCwHIJbn+Qfgc26EdslBrcO6m bGA0xYgKuHJVShM/1gWeiQVuKsgKetzEL+ZqGAYllai9wA0K0e1QedzBq5a5LyFdQutJ vsvGf8bHBEzmYlap1vVMsRG+8tNKudOjSVGTwBSJybra8AFdNQTapmrgbYvh7kPpiPCL XX6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from; bh=/Hwmh1mzxLsgmPNH/8Tagrh44ELf+We0bpa7KyRbSTw=; b=O22HBmxN0WBy79PKVFuUP1BnVznCq7mxveZdIfj/oyDj5N0JvR6KMytQCUIPJxIMQf yyTvG9r0IG8/oB+ImjDrIuDdH8t0zj+wjjHKGG2rdksyHqHHmdtTVd+ypGWKuCs+UNyC EnQsBgKSSWWjs61qS3w31mjDQ3lWjwH8NXDqLsNZdHJ5+2NP6Qv954j4cwgw7Ia14xKL EpI2OMnmNbkY78BSJ8ZnDfnR9xBNuWuJjZdAWaTZgiZpWGC/ely/I9rtDC0dcVPmUyf4 NDpt1Dvzfgy9tUu19jn2SD/01gSyehUWdL/9snJB5z4a09ciAXeVQHQK0NXxS7kowj7D zbZg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=UtschdH3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z64-v6si4828954pgd.201.2018.09.28.07.15.36; Fri, 28 Sep 2018 07:15:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=UtschdH3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729378AbeI1Uh1 (ORCPT + 99 others); Fri, 28 Sep 2018 16:37:27 -0400 Received: from hqemgate14.nvidia.com ([216.228.121.143]:4273 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729045AbeI1UhC (ORCPT ); Fri, 28 Sep 2018 16:37:02 -0400 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Fri, 28 Sep 2018 07:13:05 -0700 Received: from HQMAIL103.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Fri, 28 Sep 2018 07:13:03 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Fri, 28 Sep 2018 07:13:03 -0700 Received: from HQMAIL112.nvidia.com (172.18.146.18) by HQMAIL103.nvidia.com (172.20.187.11) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 28 Sep 2018 14:13:03 +0000 Received: from HQMAIL102.nvidia.com (172.18.146.10) by HQMAIL112.nvidia.com (172.18.146.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 28 Sep 2018 14:13:02 +0000 Received: from hqnvemgw01.nvidia.com (172.20.150.20) by HQMAIL102.nvidia.com (172.18.146.10) with Microsoft SMTP Server (TLS) id 15.0.1395.4 via Frontend Transport; Fri, 28 Sep 2018 14:13:02 +0000 Received: from moonraker.nvidia.com (Not Verified[10.21.132.143]) by hqnvemgw01.nvidia.com with Trustwave SEG (v7,5,8,10121) id ; Fri, 28 Sep 2018 07:13:02 -0700 From: Jon Hunter To: Rob Herring , Mark Rutland , Mathias Nyman , Greg Kroah-Hartman , Thierry Reding CC: , , , Ulf Hansson , "Jon Hunter" Subject: [PATCH V2 2/5] usb: xhci: tegra: Power-off power-domains on removal Date: Fri, 28 Sep 2018 15:11:47 +0100 Message-ID: <1538143910-24400-3-git-send-email-jonathanh@nvidia.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1538143910-24400-1-git-send-email-jonathanh@nvidia.com> References: <1538143910-24400-1-git-send-email-jonathanh@nvidia.com> X-NVConfidentiality: public MIME-Version: 1.0 Content-Type: text/plain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1538143985; bh=/Hwmh1mzxLsgmPNH/8Tagrh44ELf+We0bpa7KyRbSTw=; h=X-PGP-Universal:From:To:CC:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:X-NVConfidentiality:MIME-Version: Content-Type; b=UtschdH3jXB4NSMPKr4NhasP48bb5rQBU1n6N/9lZvnqKOGjbJVbSTndorRXxxkwB CnTgdKiqUk//uPl1obdAbiQ1gZTas6plYR1U0IMTxdpF7J5aGkj1KB9tTOpJOwPfA7 A4u0ye0/mjplIoXBlSF0ngLHjXIFUZ0s/VbVWp8uUwKsJtqBC9bY2DgXbC1tBx7TMD KcpBWyBHDE2lwm0WI/PrnwLTwII5ThIDu5e4q+BW0YktTrvG8L3/Jny7AaLIfUPWC0 Jbsfm46pq8y6ujiK+XpDb4FIGBJh7j/xUH3rseDuqbj61G5UwwXIYu86f9g6kMlkvX PueZYzwVREfGA== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Currently the XUSB power domains used by the Tegra xHCI controller are never powered off on the removal of the driver, however, they will be powered off on probe failure. Update the removal code to be consistent with the probe failure path to power off the XUSB power domains. Signed-off-by: Jon Hunter --- drivers/usb/host/xhci-tegra.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/usb/host/xhci-tegra.c b/drivers/usb/host/xhci-tegra.c index 4b463e5202a4..a586a7930a3d 100644 --- a/drivers/usb/host/xhci-tegra.c +++ b/drivers/usb/host/xhci-tegra.c @@ -1249,6 +1249,11 @@ static int tegra_xusb_remove(struct platform_device *pdev) pm_runtime_put_sync(&pdev->dev); pm_runtime_disable(&pdev->dev); + if (!pdev->dev.pm_domain) { + tegra_powergate_power_off(TEGRA_POWERGATE_XUSBC); + tegra_powergate_power_off(TEGRA_POWERGATE_XUSBA); + } + tegra_xusb_padctl_put(tegra->padctl); return 0; -- 2.7.4