Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org A19216053C
Date:   Fri, 28 Sep 2018 08:57:10 -0600
From:   Lina Iyer <ilina@codeaurora.org>
To:     Marc Zyngier <marc.zyngier@arm.com>
Cc:     evgreen@chromium.org, bjorn.andersson@linaro.org,
        rplsssn@codeaurora.org, linux-kernel@vger.kernel.org,
        linux-arm-msm@vger.kernel.org, rnayak@codeaurora.org,
        andy.gross@linaro.org, sboyd@kernel.org, dianders@chromium.org
Subject: Re: [PATCH] drivers: irqchip: pdc: setup all edge interrupts as
 rising edge at GIC
Message-ID: <20180928145710.GI11144@codeaurora.org>
References: <20180927171810.22968-1-ilina@codeaurora.org>
 <27d7df0d-4429-dcdd-f527-a33f9385b4e0@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <27d7df0d-4429-dcdd-f527-a33f9385b4e0@arm.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Sep 28 2018 at 04:40 -0600, Marc Zyngier wrote:
>On 27/09/18 18:18, Lina Iyer wrote:
>>The PDC irqchp can convert a falling edge or level low interrupt to a
>>rising edge or level high interrupt at the GIC. We just need to setup
>>the GIC correctly. Set up the interrupt type for the IRQ_TYPE_EDGE_BOTH
>>as IRQ_TYPE_EDGE_RISING at the GIC.
>>
>>Reported-by: Evan Green <evgreen@chromium.org>
>>Signed-off-by: Lina Iyer <ilina@codeaurora.org>
>>---
>>  drivers/irqchip/qcom-pdc.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>>diff --git a/drivers/irqchip/qcom-pdc.c b/drivers/irqchip/qcom-pdc.c
>>index b1b47a40a278..faa7d61b9d6c 100644
>>--- a/drivers/irqchip/qcom-pdc.c
>>+++ b/drivers/irqchip/qcom-pdc.c
>>@@ -124,6 +124,7 @@ static int qcom_pdc_gic_set_type(struct irq_data *d, unsigned int type)
>>  		break;
>>  	case IRQ_TYPE_EDGE_BOTH:
>>  		pdc_type = PDC_EDGE_DUAL;
>>+		type = IRQ_TYPE_EDGE_RISING;
>>  		break;
>>  	case IRQ_TYPE_LEVEL_HIGH:
>>  		pdc_type = PDC_LEVEL_HIGH;
>>
>
>Queued for 4.20, with
>
>Fixes: f55c73aef890 ("irqchip/pdc: Add PDC interrupt controller for
>QCOM SoCs")
>
>added. Please consider providing these tags in the future.

Thanks Marc. Will do.

-- Lina