Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp942176imm; Fri, 28 Sep 2018 09:14:33 -0700 (PDT) X-Google-Smtp-Source: ACcGV63hWrTGiN5hrwmfRx4zkCH1BrRR3qDL2ybIsZ3C+NooamDVqMP2yAnqsxO83mRP7CB5hbGb X-Received: by 2002:a63:81c8:: with SMTP id t191-v6mr15808134pgd.399.1538151273228; Fri, 28 Sep 2018 09:14:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538151273; cv=none; d=google.com; s=arc-20160816; b=MTZ3vaPJTX0EdEExtDMIoWmWW9k0ws2x3IcEtRGGoRx5k/rcz1nzqCRx2rYpD6eRbo gsu8CXQPSDzQSEP+tNEuHbhy7F82kjtQCV2sq2Xx5C9NtY8ZhK1VrDXoXZ3oig9y+m+g DkluiSLI5Tw2rYhTxd4RoR3gHSvy8+gN8dyhb6tyQnUu2BUXVArdnYAXHG6m7Y/t78ZQ n68lPTBvuhR0OI7jMfMWt7psv/35HZLNsz8LIzLL81ZVD8kcnxMkCdqQH2JXDZ83qqcv brRKKu433Fl/+IYLqGoxLAEZmg6+g57r1551RdVSJuG7SOm1Sfp/XTYfmVVmUumQhdrl oGFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=Rkh29N47SbgeRv+LfqZP88fUlvlu52gXlDvFM8JlW+k=; b=vkdTivotO8FqZUXUf4AepLRwvtNuvUgUv3n/0ADuEzksiJXV0hOhYUFzAxL9yPE7Eh ULbB7htHA7xrnayxfallk2bd7lAfrEfXg40gRzjF+1j0qYgaVGJ91iKyFF8Q+Gj6xSNY nJoFFnjIdB8wuvkhfbl/v3UJahCwNY9Qlf5HGzZH5lBGwziI0HB1a0EaRCgmnpZ6WJMr bxnd6HTvD292VMlZcY7+QSX/yoHWduEBeB/c5PXPOt8ZXpzK7wImDcPzIzZBiCuaYSX+ m9j7EN+hTRnuzPwQTH5YYS+gckTJo9fuAUGASglpc2G2LW7Z/F9j8bPcShZV+F09Drys X+mw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n32-v6si5052891pgm.469.2018.09.28.09.14.17; Fri, 28 Sep 2018 09:14:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729508AbeI1Whp (ORCPT + 99 others); Fri, 28 Sep 2018 18:37:45 -0400 Received: from mail78-59.sinamail.sina.com.cn ([219.142.78.59]:58698 "HELO mail78-59.sinamail.sina.com.cn" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1728643AbeI1Whp (ORCPT ); Fri, 28 Sep 2018 18:37:45 -0400 X-Greylist: delayed 434 seconds by postgrey-1.27 at vger.kernel.org; Fri, 28 Sep 2018 18:37:45 EDT Received: from unknown (HELO localhost.localdomain.localdomain)([110.184.35.163]) by sina.com with ESMTP id 5BAE50D300004B8A; Fri, 29 Sep 2018 00:03:39 +0800 (CST) X-Sender: penghao122@sina.com.cn X-Auth-ID: penghao122@sina.com.cn X-SMAIL-MID: 565916394183 From: Peng Hao To: fweisbec@gmail.com, tglx@linutronix.de, mingo@kernel.org Cc: linux-kernel@vger.kernel.org, Peng Hao Subject: [PATCH] tick: remove unnecssary check Date: Fri, 28 Sep 2018 12:03:28 -0400 Message-Id: <1538150608-2599-1-git-send-email-penghao122@sina.com.cn> X-Mailer: git-send-email 1.8.3.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Peng Hao tick_device_is_functional() has been called in the front of tick_broadcast_control, so don't need call it again. Signed-off-by: Peng Hao --- kernel/time/tick-broadcast.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/kernel/time/tick-broadcast.c b/kernel/time/tick-broadcast.c index aa2094d..74637c2 100644 --- a/kernel/time/tick-broadcast.c +++ b/kernel/time/tick-broadcast.c @@ -399,9 +399,7 @@ void tick_broadcast_control(enum tick_broadcast_mode mode) case TICK_BROADCAST_OFF: if (tick_broadcast_forced) break; - cpumask_clear_cpu(cpu, tick_broadcast_on); - if (!tick_device_is_functional(dev)) - break; + cpumask_clear_cpu(cpu, tick_broadcast_on); if (cpumask_test_and_clear_cpu(cpu, tick_broadcast_mask)) { if (tick_broadcast_device.mode == TICKDEV_MODE_PERIODIC) -- 1.8.3.1