Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp944624imm; Fri, 28 Sep 2018 09:16:38 -0700 (PDT) X-Google-Smtp-Source: ACcGV61XEbwBBcwqORXzj25tz1XTgkgjMXAUIGtk0Z+Tc5V9CM3VaaOdjCH1bK/EZJ3ckVPCPEI/ X-Received: by 2002:a65:4548:: with SMTP id x8-v6mr15731992pgr.414.1538151398258; Fri, 28 Sep 2018 09:16:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538151398; cv=none; d=google.com; s=arc-20160816; b=Rf6XzHfZiztrEJRAwiNbNx3i66C/hsFBzJbrumj8ZPRGTKfJJ+i2k7s6TepDHz/ND6 zDenLqLu2/Utr8soSIcxXw+pYY+UknaCyYUKo/HeZmneuRuH9movtocGWsD/3kWUpZrf V+g9y2nNaHRk795MDbaljt1yCyIs03Ed/H7218ge+ugajeoUgpUivcykB4SL13MHqpyz 8Lazb8woQVHdvXHvzT/fkWScO/wQZugb2fixHMmxRoIha2RMpHHeNvYOo97ss66IngvG AxDW8VVkZOsQHst9VSMm0t4pYci5vzJDxW+Z0tfsUcuKBSMxq0gGG1PV9dDvPfE9gLlZ eK9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=pWEuDD3qaUukmH4G8pD3vcrUGpAOjKGscymgfguadtY=; b=b1+ntYCFHBHs+q9uqMAQNGLpx+6RaE0UeJdyHeY3IHtwe2MrDswlyI4Wh8091Vm9SI dhZAOUE5nawadmHw00Ns+51n/G9oyFu3Mv6Wl2FLXNaoZP2sD3h86IsAxLDGHHAoVU0g UVYsn9Ih/RSMhCnhBzdoNTIZcYPQmk9qU/vmlvgUrgcVuse4y25xGryy8fxkD6ExokPi 8s9VGKzTZgCsavkyI0adpG0iZP8tDRzekKegx5Bw1Yww+2E+fjtmWOxglTp1qUTmO/oD GcepyWFSfrNj5spGgpLeCDFHg6eVqAjC5IVX2LD0mo+I1fjbE0Il5gR8+OF/ZCJlDUHB /A+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=hbqexAHh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z2-v6si5322088pfb.365.2018.09.28.09.16.21; Fri, 28 Sep 2018 09:16:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=hbqexAHh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729121AbeI1Wko (ORCPT + 99 others); Fri, 28 Sep 2018 18:40:44 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:59784 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726121AbeI1Wkn (ORCPT ); Fri, 28 Sep 2018 18:40:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=pWEuDD3qaUukmH4G8pD3vcrUGpAOjKGscymgfguadtY=; b=hbqexAHh6eULxV9StjlMSz9UT QHmfcdjZNk/Dp0JBesnkQeEkXnebaPolR4QWNRSXaLCZb2s6YOpmot6Ygj2GN4VYYuPehSmoEu5bG NY0NZNI+0Yot+0UPQAgf36g7c41999scE5rdZqv8FYmNQryZG++3TwNqNTa6LHX2zktPVbtd/0xVq mun9sDX0nz06u7eLH2BqTblqkZfygz+NZOHEFRDRaSFQmnHSHD2qDdaYXQ6bR/lIoKTEftE1l79RY bCpOnJVJ4sDfyhJNeZDoIiBVThGiT5FJFptYXChpo/tlgdbd14hLDW/6aH+7IvwzcugbnGTEFfQWo V7sgb2k7w==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1g5vR3-0000Yy-CD; Fri, 28 Sep 2018 16:16:09 +0000 Date: Fri, 28 Sep 2018 09:16:09 -0700 From: Christoph Hellwig To: Guo Ren Cc: akpm@linux-foundation.org, arnd@arndb.de, daniel.lezcano@linaro.org, davem@davemloft.net, gregkh@linuxfoundation.org, jason@lakedaemon.net, marc.zyngier@arm.com, mark.rutland@arm.com, mchehab+samsung@kernel.org, peterz@infradead.org, robh@kernel.org, robh+dt@kernel.org, tglx@linutronix.de, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, devicetree@vger.kernel.org, green.hu@gmail.com Subject: Re: [PATCH V6 05/33] csky: System Call Message-ID: <20180928161609.GD19827@infradead.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > + > +static inline void > +syscall_set_arguments(struct task_struct *task, struct pt_regs *regs, > + unsigned int i, unsigned int n, const unsigned long *args) > +{ > + BUG_ON(i + n > 6); > + if (i == 0) { Please fix your indentation - again checkpatch.pl will be helpful (even if it sometimes is a littler overzealous).