Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp951092imm; Fri, 28 Sep 2018 09:22:32 -0700 (PDT) X-Google-Smtp-Source: ACcGV61lk7mq1xm9syLiN9CWHpNMTEVo9XrHo24ybP6GVhCm4Jmxd0m585JFM8wuLZK50EckPRzW X-Received: by 2002:a17:902:6bc1:: with SMTP id m1-v6mr14881780plt.148.1538151752700; Fri, 28 Sep 2018 09:22:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538151752; cv=none; d=google.com; s=arc-20160816; b=yeJqsydRLn1ghac5Crp1zQtZkwwjsep+wveSRsW0MUYjP1xHPgnCTUQQ3z8Mf5QL3T WfB5gOO7GWjjf9cN6VQpmE9Z2rfnlyeBBnbijWbUGzfyzvkI0CTkH0LigX+ZDYkdVPb8 GCUtG2MEES0AlD9kngx7ShDbYqLlm2c9HG/FBIp1jBXFarakNdr6dB/iZd3g5rPyMZRd Gj6cY3lOKnVyGpean1e/U2yPaB/UwYVJ/Hp3L7c2IqHIFfrctwSylMiWzBexM2C03lmK NQopwwUSqtGMT9SesEXxSi2W2eGPGYRUBGrAgA+oKjoSEedZLOv9EOHTHyGF16De1Ynb txWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=aYyp5Ze8DtxvO1hAno/KDKwNGvhL82N4jREYVvohcBI=; b=hNzSyBWfejX2fcUZT0+YD5mZQYndReN1ksRhvY7oC6MFJRwTPJR1xpkzcJIJeAPpoF yplxAxxOqQQBghyi5us9JShuVV80ndN8cK2hvf8ydatrGYOtLPJjQrV3dZbNNutRyTt+ yCXW/FUAZ4DP+EsIUnU4tS2+cWOEwnqcmNOxmEeuk5FoxNFgfMX8GNn0ekb6oLU+p/hk ekLmv6LUAvHqvelmBw4SSTK9vJvsa7EsnDSFIzwHYqBXt4HU88ig8+4R1iz6GckiDk4d vfBf8Mve7v9OO2+7TcYaMQIayZI4uc9g9MQt/V61GLo0FmKRCRy0vyURvWzkUb/pF0mf 8TFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=aCGGMk6x; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o1-v6si5189602pld.479.2018.09.28.09.22.17; Fri, 28 Sep 2018 09:22:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=aCGGMk6x; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729516AbeI1Wp5 (ORCPT + 99 others); Fri, 28 Sep 2018 18:45:57 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:35482 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728873AbeI1Wp5 (ORCPT ); Fri, 28 Sep 2018 18:45:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=aYyp5Ze8DtxvO1hAno/KDKwNGvhL82N4jREYVvohcBI=; b=aCGGMk6xy65xepERN1Eoo+Mf7 xNiN6W29dwmV8iQwz59dFYtiABFPChPjg2+liatERs/tskHi6VaKA+KS4fNlChYIDCvCAx9Ijtdqp btShdzamTenUbCk1liaUsPeCPtXxtJTquGSTsnGFpii/VFhKVCDTUow6vba5rwQhfRv6jJHL1F2aR kJHdlSuWv73cTxuMLmBmB9HA2NXHyYlLe9RUwYgcAaMDwkyzmEh41iMDKXVSBXkTi1xgRhZu5a3o3 1O4obBAB0KROe2iTQ+7ZF+AcEEubhTTQ/7GosBvDr0rbiltE716Jx9Ay9Xha4BpN7paivknp6U5ra uE3kMMKYA==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1g5vW0-0002ez-LM; Fri, 28 Sep 2018 16:21:16 +0000 Date: Fri, 28 Sep 2018 09:21:16 -0700 From: Christoph Hellwig To: Guo Ren Cc: akpm@linux-foundation.org, arnd@arndb.de, daniel.lezcano@linaro.org, davem@davemloft.net, gregkh@linuxfoundation.org, jason@lakedaemon.net, marc.zyngier@arm.com, mark.rutland@arm.com, mchehab+samsung@kernel.org, peterz@infradead.org, robh@kernel.org, robh+dt@kernel.org, tglx@linutronix.de, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, devicetree@vger.kernel.org, green.hu@gmail.com Subject: Re: [PATCH V6 20/33] csky/dma: fix up dma_mapping error Message-ID: <20180928162116.GF19827@infradead.org> References: <378d4064bf29863785f4cc637999e07507e2e926.1538058840.git.ren_guo@c-sky.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <378d4064bf29863785f4cc637999e07507e2e926.1538058840.git.ren_guo@c-sky.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 28, 2018 at 08:51:17AM +0800, Guo Ren wrote: > The arch_sync_dma_for_cpu()/arch_sync_dma_for_device() implementation is > broken for some combinations that end up in a BUG() instead of performing > the necessary flushes. This should be folded into the original patch adding this code.