Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp972432imm; Fri, 28 Sep 2018 09:43:00 -0700 (PDT) X-Google-Smtp-Source: ACcGV60Y8XWJj+7yBfAfrRS2qZKo8J2YCnuOHE6KtfEXqIQvGcwzS90Du9HWZ1k8TtSqI7hEYtpE X-Received: by 2002:a17:902:6102:: with SMTP id t2-v6mr17205901plj.278.1538152980155; Fri, 28 Sep 2018 09:43:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538152980; cv=none; d=google.com; s=arc-20160816; b=yTuDQ4sPfon9u2W0nJTBGm7Yscc1yRlJQNSZV/BBDQlDZW5ox61Grr4u9VPLXaSEiC jBLE9gzd7Ky8gMUWXlGkHmMaCQneWt7X7ftycke7di48kfb4ftgvti45sCGZ47kfYRUc 3J2ZP8lUeeQdzztgJQFafIwSEFl7XeBw0Q+qMzGp0xxSsU/6B2TpKn/neY2wCDL2q3Nr G6eJjHKThJ3Mhm4edLNKNTnaCJ0LWg8ef5NlllCOcZBzAah71akTrTmWaLga6lZmX9JQ IJpMSj/uN81HOkdFk7ae1LpK3Ia9K9M38iwNnhyxsXPkZuLepoyo1sDWWtx/vUg9ZNaT OywA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=xgwjnTvayf+L6F/C4e9YJ+e1F+TcO0YCZ5iolqEmcAA=; b=Eng5UsuB6cttTgNgk9c99PVreVpvDLKXEQzlc2d6dploIOi7PY3sot/hu2m5WYPPiw xL7+IqbIUDRHJVxCHxt4FNF10Xp1Pzh6+yhkz6K7Bku4Q37MO5V/57R+ppe6lxeTmnyb weSOVPKyCEB3FeQKo1ggm0cpG6Yk9psnl0gCh0kF8rofRBL4PcBcg2wnTPh0KdYrEy6i Foa+/p5IrJKtS8xWdsUDbeVs8QDN86p0tB6IEJOmtwDa0cLD4o1mWvJyK/qkCDz+GTjK 4755IrAeZa3rQMchYTmPX+QokVyL/Svia+JSxn6nUq5TT+TOkMnprUlC3h9tPLHTICzY 6jKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=TK7Sp2ZQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e3-v6si3152905pga.369.2018.09.28.09.42.44; Fri, 28 Sep 2018 09:43:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=TK7Sp2ZQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729422AbeI1XGk (ORCPT + 99 others); Fri, 28 Sep 2018 19:06:40 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:42354 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726738AbeI1XGk (ORCPT ); Fri, 28 Sep 2018 19:06:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=xgwjnTvayf+L6F/C4e9YJ+e1F+TcO0YCZ5iolqEmcAA=; b=TK7Sp2ZQlHi9fhOjS5ytrFUBw KNuFNwWIF+pRl06KeBoPEZhtqCEMEKH3G3rZ9Ej1pLQpIUwT068tGOrzqfwtYqL7yF+qOuqGIheMU Ry8iYjmpysneJP9e9Q9JuC8ee5sae5uIJwrI0NBsO94uziD0KfijQMzQb0QUo509CaIMgtb36l9Nb mOxvTQmH1XLgogVmeOhZoIkXX0As5pu5zK9WWPiQxUd2LJM5EnTTHjyzYNh7nStQeR3n2nVgY9WcC +nvYVAYm6ocEc+bKPlMtwtK+3f9aw6gl+g+k5iKOUWBJc96JAnCfplm2Nv9PFVXjxJXckqCl5mrwy 6PCSTeSSQ==; Received: from willy by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1g5vq9-0002UY-20; Fri, 28 Sep 2018 16:42:05 +0000 Date: Fri, 28 Sep 2018 09:42:04 -0700 From: Matthew Wilcox To: Miklos Szeredi Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/9] fuse: allow caching readdir Message-ID: <20180928164204.GA20414@bombadil.infradead.org> References: <20180928154234.19270-1-mszeredi@redhat.com> <20180928154234.19270-5-mszeredi@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180928154234.19270-5-mszeredi@redhat.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 28, 2018 at 05:42:29PM +0200, Miklos Szeredi wrote: > @@ -103,6 +103,21 @@ struct fuse_inode { > /** List of writepage requestst (pending or sent) */ > struct list_head writepages; > > + /** readdir cache */ > + struct { > + /** true if fully cached */ > + bool cached; umm, you're using kernel-doc markers without formatting this comment as kernel-doc. See Documentation/doc-guide/kernel-doc.rst but I believe you should be writing this as: /** @rdc.cached: true if fully cached */ or just use /* */ if you don't want kernel-doc.