Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp983516imm; Fri, 28 Sep 2018 09:54:15 -0700 (PDT) X-Google-Smtp-Source: ACcGV63JzgNxuU/SKXvp7JAJHtJJv93xC/Qkb1nnaA38tTtbPokWoQNTContRwS1WoZ9fp/p/0tf X-Received: by 2002:a63:f848:: with SMTP id v8-v6mr15671175pgj.82.1538153655369; Fri, 28 Sep 2018 09:54:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538153655; cv=none; d=google.com; s=arc-20160816; b=IapQG1RfRpNN+/Z5z9yuVneFoQfX1IaskgtjKkTOpSO5+ozYb5huwOdEnAQArCx6Z5 orLVBJSGIAwynZaI6ju+HudTtrT7ePgg7FIzifrPjrxtg6ObFhx64xvIfHOXdAwii88F NW6ZO94CwsbLCpZzQCCOUsOvA/SjDfd3KmiiVbKcaH/MmPcebloEsIt/MtXwMgog/Rfk 0N3Vb++du6M76yBG9uypLN06eNvzGJkRoSNg2brMozjwM++tKFj0S1/rrKmvlo9maFR3 mD4XTxweGf7ihBXo65/6rGlmUD6pl86NCbU+UBGRPWk7waLqKxXErr84fCpx3yu51ZhO oNww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date; bh=T9LFQvphcgzK98ubLIlG2uWbH40QbFCi/5zGpM1OKoc=; b=frf7As4enJe5lcPQF0jKZBgTMRJrTIoOMASaybEnw3BzkxzccI5m6Qq8Ae1Vh97zO0 IaHIZZ0NCoirz+hFrk/UrB1AVUOgSI/v7yJzQimfPDXRL4Nd59/gQ0TPL3kGj5yJcacb QYw4Ukz6jktZsipMnQXkmtlYpHUl80JJBFQSQ+61+cSC2nVVbGt8jU29gHcVz4GPBixi vKPw77Ar06xhUwlgctDLT2kluk+NkNXYV5rwacz7NUT/jphhAGyOuL6312HuBOMQFsqP DxMBDf/g0lAd8IFcTBE8FHoZX4S+dvgxtW2ek68/lxs+SkhQbR8Rcz2JCQj2jZmyJJbJ OUwA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c5-v6si5138577pll.414.2018.09.28.09.53.59; Fri, 28 Sep 2018 09:54:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729124AbeI1XSb (ORCPT + 99 others); Fri, 28 Sep 2018 19:18:31 -0400 Received: from namei.org ([65.99.196.166]:34028 "EHLO namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726473AbeI1XSb (ORCPT ); Fri, 28 Sep 2018 19:18:31 -0400 Received: from localhost (localhost [127.0.0.1]) by namei.org (8.14.4/8.14.4) with ESMTP id w8SGrQD2017225; Fri, 28 Sep 2018 16:53:26 GMT Date: Sat, 29 Sep 2018 02:53:26 +1000 (AEST) From: James Morris To: David Howells cc: Randy Dunlap , Lubomir Rintel , Mat Martineau , Stephan Mueller , Andrew Morton , Linus Torvalds , stable@vger.kernel.org, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, Lubomir Rintel , Randy Dunlap , linux-kernel@vger.kernel.org Subject: Re: [PATCH] keys: Fix the use of the C++ keyword "private" in uapi/linux/keyctl.h In-Reply-To: <153809228025.23030.6619415372705612845.stgit@warthog.procyon.org.uk> Message-ID: References: <153809228025.23030.6619415372705612845.stgit@warthog.procyon.org.uk> User-Agent: Alpine 2.21 (LRH 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 28 Sep 2018, David Howells wrote: > The keyctl_dh_params struct in uapi/linux/keyctl.h contains the symbol > "private" which means that the header file will cause compilation failure > if #included in to a C++ program. Further, the patch that added the same > struct to the keyutils package named the symbol "priv", not "private". Applied to git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git next-general and next-testing. -- James Morris