Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] soc: qcom: qmi: add a prompt to QCOM_QMI_HELPERS
To:     Bjorn Andersson <bjorn.andersson@linaro.org>
Cc:     Niklas Cassel <niklas.cassel@linaro.org>, andy.gross@linaro.org,
        david.brown@linaro.org, linux-arm-msm@vger.kernel.org,
        linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20180427140358.30839-1-elder@linaro.org>
 <ec0e7861-4bf0-f135-a881-1a1de4579277@linaro.org>
 <20180928122616.GA5249@centauri.lan>
 <4025f206-631a-55e9-9b7a-89dcf3370284@linaro.org>
 <20180928172145.GA5008@tuxbook-pro>
From:   Alex Elder <elder@linaro.org>
Message-ID: <c56c556d-e9f4-16f6-b4b6-a073e2443346@linaro.org>
Date:   Fri, 28 Sep 2018 12:29:21 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20180928172145.GA5008@tuxbook-pro>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 09/28/2018 12:21 PM, Bjorn Andersson wrote:
>> I have CONFIG_IPA dependent on CONFIG_QCOM_QMI_HELPERS.  I could
>> change that to select it instead but I still think this entry
>> should be changed.

I was thinking one of two changes:
- Add the prompt string (which I suggested)
- Don't add the prompt, but remove the help and/or add a comment to
  indicate that the lack of prompt is intentional (because it really
  looked like an oversight to me)

I don't really care though; I'll change my code to select it
rather than depend on it.

> Why do you say it needs to change? I tested this by just adding a
> "select QCOM_QMI_HELPERS" in my client drivers.
> 
>> I'll mention that SLIM_QCOM_NGD_CTRL in drivers/slimbus/Kconfig
>> also depends on--rather than selects--QCOM_QMI_HELPERS.
>>
> That's wrong.

Maybe someone else should fix this, but I can do it if you like (and
if that's the case, say so).

					-Alex