Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 28 Sep 2018 21:18:53 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Alan Cox <gnomes@lxorguk.ukuu.org.uk>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Andi Kleen <ak@linux.intel.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        kan.liang@linux.intel.com, mingo@redhat.com, len.brown@intel.com,
        linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH] x86/cpu: Rename Denverton and Gemini Lake
Message-ID: <20180928191853.GJ3439@hirez.programming.kicks-ass.net>
References: <1533662247-17575-1-git-send-email-kan.liang@linux.intel.com>
 <1b7cb461-5321-86cf-3031-5ff545c3dc42@linux.intel.com>
 <20180807174851.GJ2494@hirez.programming.kicks-ass.net>
 <20180807183736.GR4238@tassilo.jf.intel.com>
 <alpine.DEB.2.21.1808072257080.1672@nanos.tec.linutronix.de>
 <20180807221725.GU4238@tassilo.jf.intel.com>
 <alpine.DEB.2.21.1808080653120.1672@nanos.tec.linutronix.de>
 <20180927142519.GB3439@hirez.programming.kicks-ass.net>
 <20180928170704.7e428738@alans-desktop>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180928170704.7e428738@alans-desktop>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Sep 28, 2018 at 05:07:04PM +0100, Alan Cox wrote:
> > > SILVERMONT_CLIENT  	0x37	     Baytrail, Valleyview
> 
> There is no such product as Valleyview. Some things talk about
> Valleyview 2 but shouldn't as that is Baytrail.

I couldn't find it either, but it is all over the linux code.

I'd be happy to remove it from this comment though.

> > /* "Small Core" Processors (Atom) */
> > 
> > #define INTEL_FAM6_ATOM_BONNELL		0x1C /* Diamondville, Pineview */
> > #define INTEL_FAM6_ATOM_BONNELL_MID	0x26 /* Silverthorne, Lincroft */
> > 
> > #define INTEL_FAM6_ATOM_SALTWELL	0x36 /* Cedarview */
> > #define INTEL_FAM6_ATOM_SALTWELL_MID	0x27 /* Penwell */
> > #define INTEL_FAM6_ATOM_SALTWELL_TABLET	0x35 /* Cloverview */
> > 
> > #define INTEL_FAM6_ATOM_SILVERMONT	0x37 /* Bay Trail, Valleyview */
> > #define INTEL_FAM6_ATOM_SILVERMONT_X	0x4D /* Avaton, Rangely */
> > #define INTEL_FAM6_ATOM_SILVERMONT_MID	0x4A /* Merriefield */
> > 
> > #define INTEL_FAM6_ATOM_AIRMONT		0x4C /* Cherry Trail, Braswell */
> > #define INTEL_FAM6_ATOM_AIRMONT_MID	0x5A /* Moorefield */
> > 
> > #define INTEL_FAM6_ATOM_GOLDMONT	0x5C /* Apollo Lake */
> > #define INTEL_FAM6_ATOM_GOLDMONT_X	0x5F /* Denvertor */
> > #define INTEL_FAM6_ATOM_GOLDMONT_PLUS	0x7A /* Gemini Lake */
> 
> Can you decide if you are going to consistently use the -view or the
> -trail naming ? I think for our use cases you mean Pinetrail, Cedartrail,
> Clovertrail, Cherrytrail as you are talking about platform (at least in
> the Intel sense of the word).

Like I said; I went with whatever is on this here page:

  https://en.wikipedia.org/wiki/List_of_Intel_Atom_microprocessors

There is no Cedar Trail, or Bayview. If you could do me a delta patch
with the names you think are appropriate i'd be happy to fold it in.
Alternatively, I can remove the tail comments entirely.

I spend entirely too much time already trying to come up with sensible
names already.