Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Nadav Amit <namit@vmware.com>
To:     "Michael S. Tsirkin" <mst@redhat.com>
CC:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Xavier Deguillard <xdeguillard@vmware.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Jason Wang <jasowang@redhat.com>,
        linux-mm <linux-mm@kvack.org>,
        "virtualization@lists.linux-foundation.org" 
        <virtualization@lists.linux-foundation.org>,
        Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v3 16/20] mm/balloon_compaction: list interfaces
Thread-Topic: [PATCH v3 16/20] mm/balloon_compaction: list interfaces
Thread-Index: AQHUVc2ED+mU4PcbWEmXX/O1MTP5s6UGHMKA
Date:   Fri, 28 Sep 2018 19:48:11 +0000
Message-ID: <7F67E16F-BC91-47B3-9A68-CF1EA226AB2E@vmware.com>
References: <20180926191336.101885-1-namit@vmware.com>
 <20180926191336.101885-17-namit@vmware.com>
In-Reply-To: <20180926191336.101885-17-namit@vmware.com>
Accept-Language: en-US
Content-Language: en-US
bcl:    0
received-spf: None (protection.outlook.com: vmware.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-ID: <F1E08C955151A9408EE1F21ABAF9AB52@namprd05.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: f7744bea-2b70-461d-f635-08d6257b52a8
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Sep 2018 19:48:11.5362
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR05MB4486
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

at 12:13 PM, Nadav Amit <namit@vmware.com> wrote:

> Introduce interfaces for ballooning enqueueing and dequeueing of a list
> of pages. These interfaces reduce the overhead of storing and restoring
> IRQs by batching the operations. In addition they do not panic if the
> list of pages is empty.
>=20
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Jason Wang <jasowang@redhat.com>
> Cc: linux-mm@kvack.org
> Cc: virtualization@lists.linux-foundation.org
> Reviewed-by: Xavier Deguillard <xdeguillard@vmware.com>
> Signed-off-by: Nadav Amit <namit@vmware.com>
> ---
> include/linux/balloon_compaction.h |   4 +
> mm/balloon_compaction.c            | 139 +++++++++++++++++++++--------
> 2 files changed, 105 insertions(+), 38 deletions(-)
>=20
> diff --git a/include/linux/balloon_compaction.h b/include/linux/balloon_c=
ompaction.h
> index 53051f3d8f25..2c5a8e09e413 100644
> --- a/include/linux/balloon_compaction.h
> +++ b/include/linux/balloon_compaction.h
> @@ -72,6 +72,10 @@ extern struct page *balloon_page_alloc(void);
> extern void balloon_page_enqueue(struct balloon_dev_info *b_dev_info,
> 				 struct page *page);
> extern struct page *balloon_page_dequeue(struct balloon_dev_info *b_dev_i=
nfo);
> +extern void balloon_page_list_enqueue(struct balloon_dev_info *b_dev_inf=
o,
> +				      struct list_head *pages);
> +extern int balloon_page_list_dequeue(struct balloon_dev_info *b_dev_info=
,
> +				     struct list_head *pages, int n_req_pages);

<snip>

Michael, can we get you ack for this patch (as well as 15/20)?

Thanks,
Nadav=