Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20180927092427.507-1-jekarlson@gmail.com> <22cc40a7-015b-6038-2093-8cd1ff0c807e@baylibre.com>
In-Reply-To: <22cc40a7-015b-6038-2093-8cd1ff0c807e@baylibre.com>
From:   Emil Renner Berthing <kernel@esmil.dk>
Date:   Fri, 28 Sep 2018 22:27:53 +0200
Message-ID: <CANBLGcwg-g=GfobJrr=BO=2gz9z_OEpmO7a5yh7hf29E6NUx9g@mail.gmail.com>
Subject: Re: [PATCH] mfd: cros-ec: copy the whole event when msg->version is 0
To:     narmstrong@baylibre.com
Cc:     jekarlson@gmail.com, sadolfsson@chromium.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        lee.jones@linaro.org, bleung@chromium.org, olof@lixom.net,
        Enric Balletbo i Serra <enric.balletbo@collabora.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 28 Sep 2018 at 14:15, Neil Armstrong <narmstrong@baylibre.com> wrote:
> On 27/09/2018 11:24, Emil Karlson wrote:
> > Commit 57e94c8b974db2d83c60e1139c89a70806abbea0 caused cros-ec keyboard events
> > be truncated on many chromebooks so that Left and Right keys on Column 12 were
> > always 0. This commit fixes the issue by restoring the old semantics when the
> > protocol version is 0.
>
> OK for me, can someone confirms it fixes the issue ??

Both this patch and the updated version fixes the same issue for me on
rk3399-gru-kevin.

/Emil

> Thanks,
> Neil
>
> > ---
> >  drivers/platform/chrome/cros_ec_proto.c | 8 +++++++-
> >  1 file changed, 7 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/platform/chrome/cros_ec_proto.c b/drivers/platform/chrome/cros_ec_proto.c
> > index 398393ab5df8..457e4940dba4 100644
> > --- a/drivers/platform/chrome/cros_ec_proto.c
> > +++ b/drivers/platform/chrome/cros_ec_proto.c
> > @@ -519,8 +519,14 @@ static int get_next_event_xfer(struct cros_ec_device *ec_dev,
> >
> >       ret = cros_ec_cmd_xfer(ec_dev, msg);
> >       if (ret > 0) {
> > +             unsigned int copy_size;
> > +
> >               ec_dev->event_size = ret - 1;
> > -             memcpy(&ec_dev->event_data, msg->data, ec_dev->event_size);
> > +             if (!version)
> > +                     copy_size = sizeof(struct ec_response_get_next_event);
> > +             else
> > +                     copy_size = ec_dev->event_size;
> > +             memcpy(&ec_dev->event_data, msg->data, copy_size);
> >       }
> >
> >       return ret;
> >
>