Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1185988imm; Fri, 28 Sep 2018 13:38:25 -0700 (PDT) X-Received: by 2002:a62:c4c5:: with SMTP id h66-v6mr245276pfk.39.1538166864669; Fri, 28 Sep 2018 13:34:24 -0700 (PDT) X-Google-Smtp-Source: ACcGV61pfx8Rc7uF/zBqGrkKNOLq54873LCNCaH9y6XK7Mnq8SYZRKolZRGzIiJFqKPHUrm1D5Q8 X-Received: by 2002:a62:c4c5:: with SMTP id h66-v6mr245250pfk.39.1538166864057; Fri, 28 Sep 2018 13:34:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538166864; cv=none; d=google.com; s=arc-20160816; b=qa6/zaSibFiPYI0lQprI8lQscQ4npiTaQN3sGSVBwurFBg1tmn5BQVNu8nvxAfWASA viZy41BMSScMpIoAlOdSjFpmwcbrqCom4OwbwB8AqwcQE/f2Eyq2/5AcUKh8JdHyF0/z qgVryxPnSHR3C4KcSAD+7gKS1cdB5odgx7HMiJ4TnIE/xwD6mmVKfrJUyQIQU9jRalSO meVNlzItM9gafxqGQRdkxS3HA6CXbJn4iCP6toPKa5DBoVnl6wD9znGePh4ZSsEQ2yV3 6GgVA+EzJHoiEpJjCXZN6W87AypCNy4ZO8fLfJoTeKSY5xehubgTdptZhiRYj8R3D9ZT QtLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-disposition :content-transfer-encoding:mime-version:robot-unsubscribe:robot-id :git-commit-id:subject:to:references:in-reply-to:reply-to:cc :message-id:from:date; bh=Et/RlWaUo8UCxdlw8zRp9fYJxyU/YFQEhIGaCNqWCkw=; b=GA9Jy56NxEaFczl0AcKtLea+03L8fNI4t6fr4EKk8uXz6wwPUW6sNrdCgzjYGR/klx wayQYlxORreFknsheL2Ceho9f+/JiCzRN42GHQdJBeOkHI7SW4PaeCboGa/AQSghYD9Y SdMx3Po9/65elqNveUeDqRxUlNTe3tEGAWOOMr4ZCzZ0QGnjKHV6hcYdbyd4f8NJo6eX /MahEaW8ahqVGnVSbpfhJ2Y+oCB/bLrYzoGLkS19SMWRbL1Em/F9CxJYKUePY9Tx5ZNd SGsScp2PAGgLoasbT71W+tjmpaPy66RNQy5JavceLXcTz7Hudd77c8YuhER5v8MpxEd0 dM3w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f9-v6si5534596plm.126.2018.09.28.13.34.09; Fri, 28 Sep 2018 13:34:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727206AbeI2C7Y (ORCPT + 99 others); Fri, 28 Sep 2018 22:59:24 -0400 Received: from terminus.zytor.com ([198.137.202.136]:60919 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726964AbeI2C7Y (ORCPT ); Fri, 28 Sep 2018 22:59:24 -0400 Received: from terminus.zytor.com (localhost [127.0.0.1]) by terminus.zytor.com (8.15.2/8.15.2) with ESMTPS id w8SKXrKB553906 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 28 Sep 2018 13:33:53 -0700 Received: (from tipbot@localhost) by terminus.zytor.com (8.15.2/8.15.2/Submit) id w8SKXq7h553903; Fri, 28 Sep 2018 13:33:52 -0700 Date: Fri, 28 Sep 2018 13:33:52 -0700 X-Authentication-Warning: terminus.zytor.com: tipbot set sender to tipbot@zytor.com using -f From: tip-bot for Peng Hao Message-ID: Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org, peng.hao2@zte.com.cn, mingo@kernel.org, hpa@zytor.com Reply-To: peng.hao2@zte.com.cn, tglx@linutronix.de, linux-kernel@vger.kernel.org, mingo@kernel.org, hpa@zytor.com In-Reply-To: <1538150608-2599-1-git-send-email-penghao122@sina.com.cn> References: <1538150608-2599-1-git-send-email-penghao122@sina.com.cn> To: linux-tip-commits@vger.kernel.org Subject: [tip:timers/core] tick/broadcast: Remove redundant check Git-Commit-ID: dc6253108f0fbff4a634055d5b8a91958ec2af81 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DATE_IN_FUTURE_06_12 autolearn=ham autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on terminus.zytor.com Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: dc6253108f0fbff4a634055d5b8a91958ec2af81 Gitweb: https://git.kernel.org/tip/dc6253108f0fbff4a634055d5b8a91958ec2af81 Author: Peng Hao AuthorDate: Fri, 28 Sep 2018 12:03:28 -0400 Committer: Thomas Gleixner CommitDate: Fri, 28 Sep 2018 22:29:35 +0200 tick/broadcast: Remove redundant check tick_device_is_functional() is called early in tick_broadcast_control(), so no need to call it again later. Signed-off-by: Peng Hao Signed-off-by: Thomas Gleixner Cc: fweisbec@gmail.com Link: https://lkml.kernel.org/r/1538150608-2599-1-git-send-email-penghao122@sina.com.cn --- kernel/time/tick-broadcast.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/kernel/time/tick-broadcast.c b/kernel/time/tick-broadcast.c index aa2094d5dd27..be0aac2b4300 100644 --- a/kernel/time/tick-broadcast.c +++ b/kernel/time/tick-broadcast.c @@ -400,8 +400,6 @@ void tick_broadcast_control(enum tick_broadcast_mode mode) if (tick_broadcast_forced) break; cpumask_clear_cpu(cpu, tick_broadcast_on); - if (!tick_device_is_functional(dev)) - break; if (cpumask_test_and_clear_cpu(cpu, tick_broadcast_mask)) { if (tick_broadcast_device.mode == TICKDEV_MODE_PERIODIC)