Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1293434imm; Fri, 28 Sep 2018 15:49:53 -0700 (PDT) X-Google-Smtp-Source: ACcGV61Mhce/+US1r6Z+cJDsOcsQGh7GU7A/lwRTiuGE8x9Rzu0P3Hfss2rr2haufsneIYk5U7pN X-Received: by 2002:a63:6054:: with SMTP id u81-v6mr617936pgb.74.1538174993606; Fri, 28 Sep 2018 15:49:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538174993; cv=none; d=google.com; s=arc-20160816; b=M7tX0MkDevq+7gUDrrQl6XGlmdKeA/g6lEkVgqLN59vex8YzYhXN/NTncYtMDDdUjX KI6KZgqdW//M/tqA51C7p5QyhHgFiwm5rkvWxuv8CtT1UBD+FlfNvp9GPBw4BLsCvcz1 52oFthXL1H97w9+A/zCWBlaS2adaHRvGplJgLk+OJyBt43MVM+rf/z+9wEhN9h7J6OZh CcbrVVJMuFAqkLhEO0kSq0uc8PyEafYehIcv5IXxzSTB97g8f87A1/TKjfTcB2MjjWPW BhmIG5CFVL4YYUUihUwO00VWJa9cL32a2h5r2G9kdNZQpJiWpQB8lPzgifiO+yOYQrTr MUhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=9RkEYaQni0JBMd8CowPIJUUqF8FVeeDKEcu3vP7h/S0=; b=jv2rXrIsKZTRjX5aVYg4W38ztB0W72NCgVAA0ZG9D48zqIY5E58/aJDCCPzZjoGXCi ie2KU1BgoappGxx0y2NAuW1zSF7so45HLgwGwS+n2tz7cWg/WDHeGp8QR6nSWPhThS4L L1ru6E3PbmQJ1DJit0OuLniRl3a+Yb0JYX7xofKmuDOrBQZzTFTjvXFModBTsTqRht+A f5E/TZPDbxxQkrbUFDG47Omhyy+u/dYE/U73x8SKuaSEXck8Aw3vb3k97xdW9L0FPec3 5+ai52AumxdRv8IAgk0Uze5uNPNYFkiIjuH/xM98lU3+GgU5ER9Djw8BL1hpFTkT8Agc Xh+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=FO61LX+h; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v20-v6si5969142pgk.586.2018.09.28.15.49.39; Fri, 28 Sep 2018 15:49:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=FO61LX+h; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727321AbeI2FPO (ORCPT + 99 others); Sat, 29 Sep 2018 01:15:14 -0400 Received: from mail-ot1-f67.google.com ([209.85.210.67]:46127 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726678AbeI2FPO (ORCPT ); Sat, 29 Sep 2018 01:15:14 -0400 Received: by mail-ot1-f67.google.com with SMTP id q4-v6so7531405otf.13 for ; Fri, 28 Sep 2018 15:49:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9RkEYaQni0JBMd8CowPIJUUqF8FVeeDKEcu3vP7h/S0=; b=FO61LX+hbTvJVg7WGXjNlLLMnuFCWdJnVR1gde1j26kU/2Wr83v3F4AZgUn04mcVGz nkT3gyzdeadiKfxe/o+KcSvwf8hUe63L7cclk9/Cua6PGiTBsY/dR27XmPAD3Y7ivch9 HZrOa4qoQfvXimTaAZN3NNf8huF15wekbTVev2UbwvXu9OJvcmHc3lLXMiCWAOzk+a5c vUtC0zLrYMS/lf1kq1V/HCytRFKuAIDWXtj727wSQULbxI+P9jiHp2yheehUtg3ePaka ZVQz5XkuFKsRYbEfZCsjIfi8iSlfRvRla9agqpM8BFG6noV2hgvhq4JTiP0vVQN530YU Et7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9RkEYaQni0JBMd8CowPIJUUqF8FVeeDKEcu3vP7h/S0=; b=uMFC5uUDp7MOliMCcHIMb1kCPmMG2qvMhqM3FLV8L5H9MnktKhc3978P4NV+mJDry2 +jT3TDngIUPTEKihD0a9lQQgojfRyE4nUbhh8Y5hvVR82ElYc6hAVkqGKDACG8nGA+PW TqOmh/qJKCggt5iKbYl3pvlBS21xsR5VPSclFcTA/SZAZDaiE7ucdyhP8CwtOLIOaK1R acHro93YGke68aDb1pB6hxnRGpsg1PfYw/MPo604xS2kDbTy5/V+GKTVW/8TYWHOTpAA SiD1cJjSJ6Ebl/ZQFx7H8AfDltBzQrJyWdsN2ZbMPS7rrQdiPMyB6CUL/B4jGFEho4Vd K4tg== X-Gm-Message-State: ABuFfogiNvYvWqxJZ7QEslZ+eCEPvTQ+83tqAzR49Bd/4c1xl0SDzdbP g2Fc+mYclnurIiYnlt6HXQPcdsekb4qyqq1ZaUeZUNjITkXgJpo1 X-Received: by 2002:a9d:2843:: with SMTP id h3-v6mr465866otd.230.1538174957801; Fri, 28 Sep 2018 15:49:17 -0700 (PDT) MIME-Version: 1.0 References: <20180927151119.9989-1-tycho@tycho.ws> <686fe047-16e6-3dfc-6284-ed574d97ad2f@gmail.com> <20180928220359.GF18045@cisco.lan> In-Reply-To: From: Jann Horn Date: Sat, 29 Sep 2018 00:48:51 +0200 Message-ID: Subject: Re: [PATCH v7 0/6] seccomp trap to userspace To: Michael Kerrisk-manpages Cc: Kees Cook , Tycho Andersen , kernel list , containers@lists.linux-foundation.org, Linux API , Andy Lutomirski , Oleg Nesterov , "Eric W. Biederman" , "Serge E. Hallyn" , Christian Brauner , Tyler Hicks , suda.akihiro@lab.ntt.co.jp, linux-fsdevel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 29, 2018 at 12:47 AM Michael Kerrisk (man-pages) wrote: > On Sat, 29 Sep 2018 at 00:35, Kees Cook wrote: > > On Fri, Sep 28, 2018 at 3:16 PM, Michael Kerrisk (man-pages) > > wrote: > > > On Sat, 29 Sep 2018 at 00:04, Tycho Andersen wrote: > > >> On Fri, Sep 28, 2018 at 11:57:40PM +0200, Michael Kerrisk (man-opages) wrote: > > >> > On 09/27/2018 05:11 PM, Tycho Andersen wrote: > > >> > > Here's v7 of the seccomp trap to userspace set. There are various minor > > >> > > changes and bug fixes, but two major changes: > > >> > > > > >> > > * We now pass fds to the tracee via an ioctl, and do it immediately when > > >> > > the ioctl is called. For this we needed some help from the vfs, so > > >> > > I've put the one patch in this series and cc'd fsdevel. This does have > > >> > > the advantage that the feature is now totally decoupled from the rest > > >> > > of the set, which is itself useful (thanks Andy!) > > >> > > > > >> > > * Instead of putting all of the notification related stuff into the > > >> > > struct seccomp_filter, it now lives in its own struct notification, > > >> > > which is pointed to by struct seccomp_filter. This will save a lot of > > >> > > memory (thanks Tyler!) > > >> > > > >> > Is there a documentation (man page) patch for this API change? > > >> > > >> Not yet, but once we decide on a final API I'll prepare one. > > > > > > Honestly, the production of such documentation should be part of the > > > evolution towards the final API... > > > > > > Documentation is not an afterthought. It's a tool for pushing you, the > > > developer (and others, your reviewers) to more deeply consider your > > > design. > > > > In Tycho's defense, he did write up documentation in Documentation/ > > for the feature, so it won't be an afterthought. :) > > So, I missed that... How do I find this Documentation/ ? It's in patch 1: https://lore.kernel.org/lkml/20180927151119.9989-2-tycho@tycho.ws/