Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1320524imm; Fri, 28 Sep 2018 16:21:58 -0700 (PDT) X-Google-Smtp-Source: ACcGV60Y4Wxg6uiPuH89oa5ql0DbGSvI+16L06fb9sDVMw7RPgqQIsj3NHpSNJABbxoUVJJeydCt X-Received: by 2002:a62:198e:: with SMTP id 136-v6mr735728pfz.103.1538176918530; Fri, 28 Sep 2018 16:21:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538176918; cv=none; d=google.com; s=arc-20160816; b=ZEE2+caPVgndZq4xkA0p2n/RYT7iIQqBldXlSZFf5I3Qi5p6Vc30kzEktOE7jwgtNY uEhuZITZ1t+tzOom6q3JPwgb6/G/7FBX+5z6+Uovxl0u1gmB4qlDb91rPAessc5Ktcxd SGHDWvsqi9gHOY0oxRXVIbWfE7g/u3scIJNdQRKIlNk75RNg+SR4epo/4LCpzZHvUpMM GxlvPn/+KDjNR3C1MgrczDodzo6vW8HwZRE7RsuMlQ6kKmB4SUMNmJGqRjBB+mBVXiuh TFJp7O7kEGrP0WilPGwe7mF0uk8l/5MSEt7s9MRr2McvR8rlrnC5MTT7LQ54ieWZIXoN zrEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=E8PGiXlYi0IBDJWj2K4hT7TJvpvWQg6NjZcEMzdTV5o=; b=alzRBp9iGavGMC4NspNLyLTm6RFJE0BsRkAaO5eskElmcsaFvAFnoLM2Z2y5wVx1YT qeqhWBHOgfDPJt7TjxphOtp5TMy9Yjt9ItbFB5bKJ6PqdQBLLk80wtsPLKic0pMa/wH2 M23NU8nAe3Ii/q2CTe+8p6RC89wd0rfUL/H7YE78oTAaB5ySUfUMCRRH0r5X+6v9OqCl 7opOqnk/QNUVy97tFUaGrHVVtlrv/TR/09nqBt2Clq3x/a6dRtxhL8TEU96SD8spd4+1 14GmGTJl+fv7AOktfJIpiPVWkZrRRM9CA3PSNBNLve2RcMPktQSNSYW2MMwwklsMPpdm 4J6g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ce1-v6si6224883plb.502.2018.09.28.16.21.43; Fri, 28 Sep 2018 16:21:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727722AbeI2Fre (ORCPT + 99 others); Sat, 29 Sep 2018 01:47:34 -0400 Received: from anholt.net ([50.246.234.109]:45470 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727672AbeI2Frd (ORCPT ); Sat, 29 Sep 2018 01:47:33 -0400 Received: from localhost (localhost [127.0.0.1]) by anholt.net (Postfix) with ESMTP id 76FE310A0414; Fri, 28 Sep 2018 16:21:32 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at anholt.net Received: from anholt.net ([127.0.0.1]) by localhost (kingsolver.anholt.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id GkQskAae_OW9; Fri, 28 Sep 2018 16:21:30 -0700 (PDT) Received: from eliezer.anholt.net (localhost [127.0.0.1]) by anholt.net (Postfix) with ESMTP id 0EBA610A1706; Fri, 28 Sep 2018 16:21:28 -0700 (PDT) Received: by eliezer.anholt.net (Postfix, from userid 1000) id E8BC82FE1B41; Fri, 28 Sep 2018 16:21:26 -0700 (PDT) From: Eric Anholt To: dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org, boris.brezillon@bootlin.com, Eric Anholt Subject: [PATCH 3/4] drm/v3d: Add some better documentation of the in_sync arguments. Date: Fri, 28 Sep 2018 16:21:25 -0700 Message-Id: <20180928232126.4332-3-eric@anholt.net> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180928232126.4332-1-eric@anholt.net> References: <20180928232126.4332-1-eric@anholt.net> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since this is UAPI, it's good to document what exactly the guarantees we're providing are. Signed-off-by: Eric Anholt --- include/uapi/drm/v3d_drm.h | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/include/uapi/drm/v3d_drm.h b/include/uapi/drm/v3d_drm.h index 7b6627783608..f446656d00b1 100644 --- a/include/uapi/drm/v3d_drm.h +++ b/include/uapi/drm/v3d_drm.h @@ -58,6 +58,11 @@ struct drm_v3d_submit_cl { * coordinate shader to determine where primitives land on the screen, * then writes out the state updates and draw calls necessary per tile * to the tile allocation BO. + * + * This BCL will block on any previous BCL submitted on the + * same FD, but not on any RCL or BCLs submitted by other + * clients -- that is left up to the submitter to control + * using in_sync_bcl if necessary. */ __u32 bcl_start; @@ -69,6 +74,11 @@ struct drm_v3d_submit_cl { * This is the second set of commands executed, which will either * execute the tiles that have been set up by the BCL, or a fixed set * of tiles (in the case of RCL-only blits). + * + * This RCL will block on this submit's BCL, and any previous + * RCL submitted on the same FD, but not on any RCL or BCLs + * submitted by other clients -- that is left up to the + * submitter to control using in_sync_rcl if necessary. */ __u32 rcl_start; -- 2.18.0