Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1368505imm; Fri, 28 Sep 2018 17:28:41 -0700 (PDT) X-Google-Smtp-Source: ACcGV60AI/iwuYbUJ+Lw+rgrGE4otx1nwEEZOBo3vzjR/aqK4mj7VJpSQXZvathhjAx+pGltI1Av X-Received: by 2002:a63:df04:: with SMTP id u4-v6mr891446pgg.434.1538180921128; Fri, 28 Sep 2018 17:28:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538180921; cv=none; d=google.com; s=arc-20160816; b=Xc4EYZK8aTiosXgg1GKd3xK1sdpN3Ara/EIDunXOhj4kyXN/np0WhFSTx7KRClTPhQ JVsNHbX+DqNeSaooU+rrnHAXg7H3357RQS+nMx1TRBC14NUyW7fPIhHCd90m4Tx2kV8q 8CRRmDPAMS+u3cKGQotEGmY37i7YklIx92ChKqAwGy6VkNuvGA8TEhULNYyPq10V/qsh 87nt8HnOo3PtgUgcqCoo/dCsK/jczEyqqT//wRUjAVPX8HsBFQeCMrsHoDsOfTgNiuR3 mT8TzPIxoVwYc50sJlmNEO8PDMEKm8Az/5djtb3r3JXMoZfC93oseaqBVLO1J6KgSqwC I8Iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=XwM5EU6Ra1KA12E1Q+lvFK8Gvksjkpk/Y7BJdSQF34g=; b=CQsD3bA5gIemtG95qW2V105pgPesta6zujXaWlkVp2gw5L5LrA5g8lEEAuV2FDE9pB 4b6SE+nEa019ANKgi2iX9CGvijpVZ2kR5tuLnWmiTgefjpqLE0mIsObENeWht4+mQowq +PXIowUFPwUpOpluBy5G6Onpn9N394jkt95cRmd/qIkx4dxuKvCT5iAUFkaz8Sre6kHY YmT5K6YTS29K444tfou5RjcqntmjHbrU4pEnhzBrvWa9029PF4shOHeD8ngr+X8JXeDS 6VMjZ+vd90Tll2wk2efJICQP9e+0MSA5s65RgBMyg9fopNLadkWDRFgj9G7Rnp/2vm+i cnPg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m4-v6si5868906plt.432.2018.09.28.17.28.26; Fri, 28 Sep 2018 17:28:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727406AbeI2GyK (ORCPT + 99 others); Sat, 29 Sep 2018 02:54:10 -0400 Received: from muru.com ([72.249.23.125]:57826 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726287AbeI2GyK (ORCPT ); Sat, 29 Sep 2018 02:54:10 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 8C0D880C0; Sat, 29 Sep 2018 00:32:19 +0000 (UTC) Date: Fri, 28 Sep 2018 17:27:53 -0700 From: Tony Lindgren To: Dmitry Osipenko Cc: Maciej Purski , Mark Brown , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, Carlos Hernandez , Marek Szyprowski Subject: Re: [PATCH] regulator: core: Pass max_uV value to regulator_set_voltage_rdev Message-ID: <20180929002753.GT5662@atomide.com> References: <20180615112916.GK112168@atomide.com> <1529330913-11152-1-git-send-email-m.purski@samsung.com> <20180702080505.GN112168@atomide.com> <95655644-ef41-f5bd-7e8e-a257d48cd020@gmail.com> <20180928202251.GM5662@atomide.com> <2c0132ff-ea0f-f19e-ebfb-a0d077565d2c@gmail.com> <20180928224109.GS5662@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Dmitry Osipenko [180928 23:55]: > On 9/29/18 2:17 AM, Dmitry Osipenko wrote: > > On 9/29/18 1:41 AM, Tony Lindgren wrote: > >> I'm still getting these errors after init: > > > > Thank you very much again, seems I got what's wrong with your case. The ti-abb-regulator driver sets the "abb->current_info_idx = -EINVAL" on probe and that value is getting updated only after the first voltage change, hence _regulator_get_voltage() returns -22. OK that's starting to make some sense now thanks. > > Please try this patch: > > I've revised the patch and here is the current final version. Hey cool this one works now :) I suggest you rework the whole series with these fixes. I recall the series had a problem with git bisect too between the patches. It will make life easier for other people who may need to git bisect these patches. Thanks, Tony