Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1451821imm; Fri, 28 Sep 2018 19:38:26 -0700 (PDT) X-Google-Smtp-Source: ACcGV60qjjKCVean40qnqLDNgPMHujdZ6pJnFoAm6MxjgkSKzA8ObS0zVJcvEMN4mD04m2D0PFGu X-Received: by 2002:a17:902:28a8:: with SMTP id f37-v6mr1266614plb.264.1538188706522; Fri, 28 Sep 2018 19:38:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538188706; cv=none; d=google.com; s=arc-20160816; b=lHW3Gp4gklEBph5VXXaA0vGvXpudeEOgYiIJwetxYQ40ryloRvRiw1bcmecBqHwx1G V7rMyiTuQLDcUZ65etpMktawjjMGNS5CZ7rs7NMglgVTVUXu9sjuQtXtVoS2TIgGc6bm VloJX10Sckxek+qrZWSWf5c2WNOsHNfjIV/AETqroXwWWy4mnLu4sl1cIe+bn5xkLqfm UDUbvrekQr7elUISAqPFplk/Ko/u0U7xF8amBTwiXUZcldbH1xQ252zDeTx5FOV0btx9 RanmtMUFyZuEGuwWRFbnltFzsdIgYdHZh21XgvHbKwG7GXcIBlBA9p/HFyEzd3q71MCY K6vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :references:in-reply-to:date:cc:to:from:subject:message-id; bh=jG4fn/ovsA5liyNigFstP0Egi32ny2Klg2sBoVyIsko=; b=YNhonHDtPi9cpbiORuNCZTyrGlgxq9dQ2yb4/yVfJLya0wom0sYUfNUSoDK2nfmEHL q44kUJbQ9+C1Yta+CVpBCfpEDZq884w54o3dePET6qKVlnrrsBO1hz2KDxIoCOd+P16y nGYST/SmvOKlay2j5eoqN8zZH8ZvNjSfdfTcv2KjmWUjQNjwwRoG3LkQzT5QaOUVVn8S FwcJMTV2+Obl8qdLXH4Nf6HFYHseekz9AHxm+f3t6YyigqHJe5v3PxYSCYaIaX8CbUwk iMKrLdtwlGu7yKc8dIWj1kKQed5sSFuSrK/4sy9u/AEqx4MQK05moNEGnjmKJiRAsCwi avTg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i5-v6si6095896pgg.84.2018.09.28.19.38.09; Fri, 28 Sep 2018 19:38:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727401AbeI2JEl (ORCPT + 99 others); Sat, 29 Sep 2018 05:04:41 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:51391 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1727359AbeI2JEl (ORCPT ); Sat, 29 Sep 2018 05:04:41 -0400 X-UUID: ada4b099957041919309771b32e2dfb8-20180929 Received: from mtkcas08.mediatek.inc [(172.21.101.126)] by mailgw01.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 885499414; Sat, 29 Sep 2018 10:37:59 +0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by mtkmbs08n1.mediatek.inc (172.21.101.55) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sat, 29 Sep 2018 10:37:57 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Sat, 29 Sep 2018 10:37:56 +0800 Message-ID: <1538188676.3674.1.camel@mhfsdcap03> Subject: Re: [PATCH 1/2] mmc: dt-bindings: add "bus-clk" for MT2712 From: Chaotian Jing To: Sean Wang CC: Ulf Hansson , Rob Herring , Mark Rutland , Matthias Brugger , Ryder Lee , Wolfram Sang , , , , , , Date: Sat, 29 Sep 2018 10:37:56 +0800 In-Reply-To: <1538156040.30348.89.camel@mtkswgap22> References: <1538134855-11198-1-git-send-email-chaotian.jing@mediatek.com> <1538134855-11198-2-git-send-email-chaotian.jing@mediatek.com> <1538156040.30348.89.camel@mtkswgap22> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2018-09-29 at 01:34 +0800, Sean Wang wrote: > On Fri, 2018-09-28 at 19:40 +0800, Chaotian Jing wrote: > > On MT2712 MSDC0/3, HCLK/bus-clk need gate/ungate together, > > or will hang when access MSDC register. > > > > Signed-off-by: Chaotian Jing > > --- > > Documentation/devicetree/bindings/mmc/mtk-sd.txt | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt > > index f33467a..182299b 100644 > > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.txt > > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt > > @@ -22,6 +22,7 @@ Required properties: > > "source" - source clock (required) > > "hclk" - HCLK which used for host (required) > > "source_cg" - independent source clock gate (required for MT2712) > > + "bus_clk" - bus clk used for internal register access(required for MT2712 MSDC0/3) > > use a full name in the description such as changing "clk" to "clock" and > > add an extra blank char prior to left parenthesis > OK, fixed at v1 version. > > - pinctrl-names: should be "default", "state_uhs" > > - pinctrl-0: should contain default/high speed pin ctrl > > - pinctrl-1: should contain uhs mode pin ctrl > >