Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Date:   Sat, 29 Sep 2018 17:26:19 +0900
To:     zhe.he@windriver.com
Cc:     pmladek@suse.com, sergey.senozhatsky@gmail.com,
        rostedt@goodmis.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] printk: Fix panic caused by passing log_buf_len
 to command line
Message-ID: <20180929082619.GA582@tigerII.localdomain>
References: <1538145961-52724-1-git-send-email-zhe.he@windriver.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1538145961-52724-1-git-send-email-zhe.he@windriver.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On (09/28/18 22:46), zhe.he@windriver.com wrote:
> This patch adds a check to prevent the panic and a check to report if someone is
> setting it over 4G.

OK, He Zhe, you are almost there.
Let's do the series the following way:

- four patches
- each change goes into a separate patch
- the first two patches Cc stable


patch #0   Cc stable

---
	unsigned int size;

	if (!str)
		return -EINVAL;
	size = memparse(str, &str);

---


patch #1   Cc stable

---

        len = sprintf(text,
                      "** %llu printk messages dropped **\n",
                      log_first_seq - console_seq);

---


=====================================================================

patch #2

---

#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

---


patch #3

---

      if (size > UINT_MAX) {
              size = UINT_MAX;
              pr_err("log_buf over 4G is not supported.\n");
      }

      ...
---

	-ss