Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1901547imm; Sat, 29 Sep 2018 06:22:17 -0700 (PDT) X-Google-Smtp-Source: ACcGV60od1HO6dAnqRzpz8MqdfPVsIfBaNwoB6oCnqkQ/8FSgNZBj6lkHcZcSDnJibF1aI10OxXV X-Received: by 2002:a17:902:bd04:: with SMTP id p4-v6mr3261742pls.265.1538227337855; Sat, 29 Sep 2018 06:22:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538227337; cv=none; d=google.com; s=arc-20160816; b=XgupdnZ9xouZXhAnGR6dppBS6LT/yxkc+J415NzH7DWeR0OHSihUCSjo1T0N/t/ipg dGNQSPikCtWNbD6sQtm8SFLwMoOgNv5yRCWi48k8Y6JtnZ9cLTBmEfYbuW39da7QapNc oiejnnbSqnjtUYxoUS5Y8wk9Pl8PljZ8qjEB/HapdSpBfrZHi6Y2+xZEGaXFfKvencZk KqNiaMKVZ0tAIDLn1BZf+O1rAvtVL+EOtXIcvS7opnz7CGJX47c66pkr5SVRv+anSeWO TKqIliLvz2m2qiFEmuAVp+FnjTULLlvn1FIrPOin4lzVD0t4n5PLgjg944uWqNCfE4Uz Loyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=Runsj6cYXCgjBf6b0c+0D0p8kBFFt75minmQTDVrJxY=; b=lB9/nPQrdGrs11ql8m4LPbQztYp7Vy+BvlbENk3ZunU1WvmAkL6AnYG+ro4GMqWW2X feq4/TvHO5zcPG36rwedh+JHjlRg2tC1YzVWsv6ikVYnj9wBhHFMi6+w8Btk7UOa/nnr t0GztU465rCJLFNHRDBrMZwgtwyuCaUIO4RqmGpWfq67W2i/Jm5Xh6+d6nFIcnOCaM2r 5HcTDoC1a43IKwWNaGfE5demZcrAPLO/EM9mNghl4zvaFy13JpiyWsz40LD5C5SRqdzl 0aeAt3DYW6fuWycGLiB93wBh9LlxgJviScS+x/Z8umW37R7tvnXS4E+1rFZsReFQ6kJu /85g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ayeq0b+T; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q17-v6si8173413pfi.183.2018.09.29.06.22.03; Sat, 29 Sep 2018 06:22:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ayeq0b+T; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728228AbeI2TuW (ORCPT + 99 others); Sat, 29 Sep 2018 15:50:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:51770 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727876AbeI2TuW (ORCPT ); Sat, 29 Sep 2018 15:50:22 -0400 Received: from [192.168.1.75] (cpe-24-28-70-126.austin.res.rr.com [24.28.70.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AC90C206B2; Sat, 29 Sep 2018 13:21:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1538227315; bh=tv+n1u2sa4yJQvanWPNPraodOjf0ubQ52vfH0h72ofs=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=ayeq0b+TQm4kngOpdMUBlEKMco0VChUxSiOlUXxsbdEK9uoPNDUTsDUb/QJPTbGoD WGBZXPLY/4xPOC02fWpQPugSv0Io5CLCqoyn9ixfR0yZw5HrztN3GltmOW3jWrDecT y7G8z0mPd3P5Ir9V6BgEn8FILW/HqUWCswJ+vkQ4= Subject: Re: [PATCH v2] gpiolib: Show correct direction from the beginning To: Ricardo Ribalda Delgado Cc: jhugo@codeaurora.org, swboyd@chromium.org, LKML , Linus Walleij , linux-gpio@vger.kernel.org References: <20180921103604.13361-1-ricardo.ribalda@gmail.com> <20180921103604.13361-2-ricardo.ribalda@gmail.com> <153803107307.119890.10052910965015646333@swboyd.mtv.corp.google.com> <3e07cab8-0f3e-7474-8f6d-e6bb16e8f998@codeaurora.org> <5aea282d-6fc9-cd70-cec4-10f28aa819b9@codeaurora.org> From: Timur Tabi Message-ID: <9df3f61f-ac54-f5b1-6b86-db539e07c5bd@kernel.org> Date: Sat, 29 Sep 2018 08:21:54 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/29/18 1:23 AM, Ricardo Ribalda Delgado wrote: > In fact gpiochip_init_valid_mask is called some lines after in the > same function. We could reorder the function. Would that work for you? It might. It might break something else, though. > The driver breaking is upstream? Yes. > Is it possible to access the hardware? Linaro and some Linux OSVs should still have systems, but I usually just ask Jeff to test code for me.