Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1953941imm; Sat, 29 Sep 2018 07:24:30 -0700 (PDT) X-Google-Smtp-Source: ACcGV6176UA81ZgyI4EBqTrsPJwXX0DYof4FTEFM5kgLS8NesEhOkC9gPDvWKkcO8p4QJf9gP1Hb X-Received: by 2002:a62:c957:: with SMTP id k84-v6mr3374166pfg.205.1538231070793; Sat, 29 Sep 2018 07:24:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538231070; cv=none; d=google.com; s=arc-20160816; b=chGzrBNo6UfXrC71i0gjm/13XzJrfbaNSsWu52gcrVVgY3rSjNsDcYbng0Hym5FvYa MZR5u1uYyLFSyiHOko3dGMybKKnQ6g2xkDE84ScoConyomFu/y3Ha/d/LuWrp6IzJysj 01x+biTpCTXFc77sVpEq6vAlfW1LPDhCHwLBWg2wgq0eVy8JddV3Y+S9aZUInG1pB/Gb zYjt+CbG9I6pQ+Ux+HoETJ+KW/EoRi2yCAz6PEVgkGhgjrPR676Y0RvFBPCYYPEIMAp4 tJzyFZGX6s3z4MVwAr4i5RXSW3VFkUvvCoep/fM8WCToMUgz6xPMZ+nN+yLyXHcRp1k5 oPgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=ItT1DcEMAppPMZ6luIPno3BA87CBEqYsE+4cbTfqizE=; b=C/GMEd6/I8NjLL85GOocBY7+8BQT/GOnjJ4aznTb9mGS0OJo3wIwJl9vXm33yxJd+p GgzKn8P57wVPAcC0zxlJw/1xiXcNAkJFF+qn3G6Dde1KcNg4UMcpKWXFrwjLiRm5uV8q /wUIMhgGu8NqGoWnZBQP0HZD6Q8B4dDRUbErLTx+PN+xbrzn7CKfwmNgyHBKLtzV+yv9 daxk5OHnuCH/Kb4pGmiXyumFdsx0f/leAfTb6pOBFIKnQtXiGA5Bvdsy2USQOk3U8/VU oJslbTT6btMltImE835uQvXhw2Hy4ju2azEJRtN5UfoHovYVWH6HhZr/x6jo4qTNP5TB 3CFA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y8-v6si7506542plk.240.2018.09.29.07.24.01; Sat, 29 Sep 2018 07:24:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728252AbeI2Uwe (ORCPT + 99 others); Sat, 29 Sep 2018 16:52:34 -0400 Received: from mga02.intel.com ([134.134.136.20]:38077 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728089AbeI2Uwe (ORCPT ); Sat, 29 Sep 2018 16:52:34 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Sep 2018 07:23:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,320,1534834800"; d="scan'208";a="77136234" Received: from rchatre-mobl.amr.corp.intel.com (HELO [10.251.9.142]) ([10.251.9.142]) by orsmga007.jf.intel.com with ESMTP; 29 Sep 2018 07:23:55 -0700 Subject: Re: [PATCH V5 0/6] perf and x86/intel_rdt: Fix lack of coordination with perf To: Peter Zijlstra , Thomas Gleixner Cc: fenghua.yu@intel.com, tony.luck@intel.com, mingo@redhat.com, acme@kernel.org, gavin.hindman@intel.com, jithu.joseph@intel.com, dave.hansen@intel.com, hpa@zytor.com, x86@kernel.org, linux-kernel@vger.kernel.org References: <20180920141150.GY24124@hirez.programming.kicks-ass.net> <77383a1e-f343-7529-24cf-874f0999507d@intel.com> <20180928065830.GE3439@hirez.programming.kicks-ass.net> From: Reinette Chatre Message-ID: <42c2b375-dbb9-11a3-8e2f-bec744e73b10@intel.com> Date: Sat, 29 Sep 2018 07:23:55 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180928065830.GE3439@hirez.programming.kicks-ass.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/27/2018 11:58 PM, Peter Zijlstra wrote: > On Thu, Sep 27, 2018 at 10:39:01PM +0200, Thomas Gleixner wrote: >> On Fri, 21 Sep 2018, Reinette Chatre wrote: >> >>> Dear Maintainers, >> >> Sorry for replying late. >> >>> On 9/20/2018 7:11 AM, Peter Zijlstra wrote: >>>> On Wed, Sep 19, 2018 at 10:29:05AM -0700, Reinette Chatre wrote: >>>>> Reinette Chatre (6): >>>>> perf/core: Add sanity check to deal with pinned event failure >>>>> perf/x86: Add helper to obtain performance counter index >>>>> x86/intel_rdt: Remove local register variables >>>>> x86/intel_rdt: Create required perf event attributes >>>>> x86/intel_rdt: Use perf infrastructure for measurements >>>>> x86/intel_rdt: Re-enable pseudo-lock measurements >>>>> >>>>> Documentation/x86/intel_rdt_ui.txt | 22 +- >>>>> arch/x86/events/core.c | 21 ++ >>>>> arch/x86/include/asm/perf_event.h | 1 + >>>>> arch/x86/kernel/cpu/intel_rdt_pseudo_lock.c | 372 ++++++++++++-------- >>>>> kernel/events/core.c | 6 + >>>>> 5 files changed, 261 insertions(+), 161 deletions(-) >>>> >>>> Yeah, these look good, thanks! >>>> >>>> Acked-by: Peter Zijlstra (Intel) >>>> >>> >>> Could you please consider this series for inclusion into v4.19? >> >> So in principle I'm having no objections as this really is mostly a RDT >> only issue. >> >> Peter, any objections against the Perf part of it, aside the core patch >> which is an obvious fix? > > Nope, look up a few lines to observe my Ack ;-) > I interpreted Thomas and Peter's responses to mean that there are no objections for this to be included in v4.19 as a fix. If I understand the tip branches correctly the core patch seems to be headed to v4.19 while the rest (excluding the final patch "x86/intel_rdt: Re-enable pseudo-lock measurements") are headed to v4.20. Have you decided against including this into v4.19 or did I misunderstand the responses and/or branches? Thank you for helping me to sort this out Reinette