Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2085930imm; Sat, 29 Sep 2018 10:05:52 -0700 (PDT) X-Google-Smtp-Source: ACcGV62Yscz2om6cndS0tw1iGYs740wt5fvBb3kkomsMeZpmIn8LvXHJJmd5Dd63M7/C2tBo4f5t X-Received: by 2002:a63:e00d:: with SMTP id e13-v6mr1252785pgh.114.1538240752718; Sat, 29 Sep 2018 10:05:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538240752; cv=none; d=google.com; s=arc-20160816; b=Q+7iRjnrWUuCwoDEFSU2g9rE4l68Dj8Q22sLRk6+J2Ej9Z88VI6HXlSyuT3WmHjFUi mPZcIbG5y8hP01S5aDJmmQQdgV3apL4P22hcDAtIwku/qsFHBLpQlLv2rcsTsnmsGGYT 8f2KsFp+zytXUcc34XFgT/At6i8kmMGgFpULPVJEwzkUNWOkPFL1sHuMswiJO/fFtfPJ VAt0562FFGHoxmUBBoHKtTaopH64RAEkZPPqzG/94LkbDLDe/h58KjFmDdzyHf9Tluqp /YydNKsOogL8IYBpQAQzMTd/yB82mnZTGHQQfybLHwxZf0eYXpxGQSrdokFE3G7rDncY Shqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=8TEyNOXiA7oDvCiDLvhuRR99dF0xNpnHJuLP0GjJPeQ=; b=MjyhT7NXDl8swJaNQqDqS7I69fXh91qeTn42y6AdBczEeuOuXIay0ZaoTv9q9/wgU7 s4hjEZE6aAC85EY8qx61KUFV3O6Is16eVLoBpIdatNJIh6arn2A6rM8MH2PPpkEn2IvJ 3nwtoLmoexh4hO/vRrKvrwJ3hVx9V6puhqLIlg0iwHpxWNniHpHOcfgbioz3o7zGlxzD lm24jO59ekCi55jvURV8rPKFFvThT1qDjFjY/M8QYrbyEvhIEpWDLzLeQtniS72gI3rX 4M6XKcml02pLIRXOxHJJfaumPjbIyuvUzdzPqo15CzC3ekCUE68vuPD++5w70ZmDzog2 RcUw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t16-v6si4065700ply.460.2018.09.29.10.05.38; Sat, 29 Sep 2018 10:05:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728569AbeI2XeY (ORCPT + 99 others); Sat, 29 Sep 2018 19:34:24 -0400 Received: from smtp2200-217.mail.aliyun.com ([121.197.200.217]:54556 "EHLO smtp2200-217.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728419AbeI2XeY (ORCPT ); Sat, 29 Sep 2018 19:34:24 -0400 X-Alimail-AntiSpam: AC=CONTINUE;BC=0.198729|-1;CH=green;FP=0|0|0|0|0|-1|-1|-1;HT=e02c03292;MF=ren_guo@c-sky.com;NM=1;PH=DS;RN=18;RT=18;SR=0;TI=SMTPD_---.CxVfrl-_1538240701; Received: from localhost(mailfrom:ren_guo@c-sky.com fp:SMTPD_---.CxVfrl-_1538240701) by smtp.aliyun-inc.com(10.147.40.7); Sun, 30 Sep 2018 01:05:01 +0800 Date: Sun, 30 Sep 2018 01:05:00 +0800 From: Guo Ren To: Christoph Hellwig Cc: akpm@linux-foundation.org, arnd@arndb.de, daniel.lezcano@linaro.org, davem@davemloft.net, gregkh@linuxfoundation.org, jason@lakedaemon.net, marc.zyngier@arm.com, mark.rutland@arm.com, mchehab+samsung@kernel.org, peterz@infradead.org, robh@kernel.org, robh+dt@kernel.org, tglx@linutronix.de, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, devicetree@vger.kernel.org, green.hu@gmail.com Subject: Re: [PATCH V6 05/33] csky: System Call Message-ID: <20180929170500.GE27796@guoren-Inspiron-7460> References: <20180928161609.GD19827@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180928161609.GD19827@infradead.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 28, 2018 at 09:16:09AM -0700, Christoph Hellwig wrote: > > + > > +static inline void > > +syscall_set_arguments(struct task_struct *task, struct pt_regs *regs, > > + unsigned int i, unsigned int n, const unsigned long *args) > > +{ > > + BUG_ON(i + n > 6); > > + if (i == 0) { > > Please fix your indentation - again checkpatch.pl will be helpful (even > if it sometimes is a littler overzealous). Ok, I'll use checkpatch.pl.