Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2102519imm; Sat, 29 Sep 2018 10:24:55 -0700 (PDT) X-Google-Smtp-Source: ACcGV60R4mF8WkAxSLAtCvfi1L00h5R6wTEgv8TRDw6kH3hYjulZ34vI6qQrduQadEMpxR8shosX X-Received: by 2002:a17:902:b7c3:: with SMTP id v3-v6mr4116105plz.182.1538241895337; Sat, 29 Sep 2018 10:24:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538241895; cv=none; d=google.com; s=arc-20160816; b=DlbbvpMExAGv0Yv9DM3XtN/n5SckSikQ8Sh/iNlyWB/T+I/A/kt5HxtpcgDxP+PAj+ cyO6HTdnX3RHU8GheGGkZLsuqWYnoqwTPspmu/Qq4DwrGMUs9WXnbp4MwFHVqLGtVoG4 JnUgf0jouo6eBl8FwwmhhgT/HM9HhRTaKXIYu9FTWN0e0H7fIxwKSdEMA2byBfQT/K0O GU5EW1u/bWFjfWjP1gwP7aEj0RgtdHhsjGGGGpjyw6QfP/SxUf1C/oRp0wW1wkhYb5WZ SFKzEzAI7+pwX//IEQfHfWuKKHOAXTksfMmCYcUl2Imi/jmxQ3pw+eQdXjDSha0/CJ/w 283w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:message-id:date:subject:cc:from :dkim-signature; bh=h/9LQyK+PGpkRdU4jpdccd2cOV4yMwkQaDov6ziZ2o8=; b=XwYVe1Z/DSjhQDPRuy9XVzvAyZR/M4r1F+hJvSk05n1RUbo1L6zlNedOudHIV7Ip6U C2IS4kF/tnsW1/qL6xeztcwh+N0WfP8W/oxPNHQiJVuuEjxKVfcOtlRW+S/uVy1njHHp gz0ZCJCGdKP15L4TnpqHu1kUfdSNkn4OcW0/zSOjNzcPCJk4P39skO4X41eWueyj+vrL Re9kyUWY/HRuBBHrQ1lZjUC8jBMkWcORTANGKkSTSUHforIsCm9YCzGw5DpWh+Kpb3Z3 fp58q+xuGlrlGEuHFR6nLGZm+olXFRLEysUkkqpCWp4Yf2ZZDFaz3hKYp1G71QlKhft9 1MVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=HVWiXCDy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h4-v6si4807060pgj.507.2018.09.29.10.24.40; Sat, 29 Sep 2018 10:24:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=HVWiXCDy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728523AbeI2Xxt (ORCPT + 99 others); Sat, 29 Sep 2018 19:53:49 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:40864 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728364AbeI2Xxt (ORCPT ); Sat, 29 Sep 2018 19:53:49 -0400 Received: by mail-wm1-f68.google.com with SMTP id o2-v6so4913915wmh.5 for ; Sat, 29 Sep 2018 10:24:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=h/9LQyK+PGpkRdU4jpdccd2cOV4yMwkQaDov6ziZ2o8=; b=HVWiXCDywZ8+y3Ie+zQiio/StNW9AWgpfpC+yg0ZPZm9IU6fc2m6BdoR/glfbc74Rr rKqc4bjj1ol1iM9fvQRuu/kXBILGtCobj8dbUfHE0H17wnEEtEcaERNiQ3AFQM8GgIPK xkFbcZ0LE8weVEFQRR5gUyW2Yt2zyQJkxqpNPPKPfN1LD8pKR3oYiJbXaOJvXMAGDhis B44gk2EPoiU4RSmhp7maoANk1glkmXmtwOtKIT2KHQ32WxYATvUVwUaLzTdpODoaE+Dd StJ5WSy/fec3e3gB08+mlUzvSu4orPTzwirp9YcKjRaol3487fmmSMkVXyrwNWMuzJvs 3YHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=h/9LQyK+PGpkRdU4jpdccd2cOV4yMwkQaDov6ziZ2o8=; b=a+C0luI4b3K6DJsaRYwiGpfOyxbLjtfti0R//iTZv9zWFojIslLGMuaIujSRJLfqI3 9nEtD33VG4IPStPwomLUMxyuCFPsTQMUQLJMKrUOiyEQGa4v7L6rW9GS0we3VTrJBJTT CNvwmefYv0gRtlXwuHdWoDN8xkVEYmbjSSvRH+89Flr9c/T2l0FvN6/haHqQvHsg67xx rhrgUyT+YAW47ju5TbeFlgitgXS9ervBuqSkSQp8hEXneKfNSPG0loxVo1vni9TUatow DMPICMB/RIsxvrBT1T8E+OYEf9p57rpfiGrUlygWTe1nxLLllZzniSE/eflPNW6nvpEU wjxA== X-Gm-Message-State: ABuFfogQ6NwwosCWpZJWhs3tx8P/Q9F5Rh1R7T3/PcgvbhLokqmL0Yx7 VB+W4YUYhqOxTFQebrYHyCg= X-Received: by 2002:a1c:5852:: with SMTP id m79-v6mr4725333wmb.118.1538241874166; Sat, 29 Sep 2018 10:24:34 -0700 (PDT) Received: from localhost.net ([2a01:388:3ce:110::1:5]) by smtp.gmail.com with ESMTPSA id x5-v6sm4526089wmi.37.2018.09.29.10.24.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 29 Sep 2018 10:24:33 -0700 (PDT) From: Aymen Qader Cc: Larry Finger , Aymen Qader , Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] staging: rtlwifi: Return -ENOMEM instead of -1 Date: Sat, 29 Sep 2018 18:24:29 +0100 Message-Id: <20180929172429.21039-1-qader.aymen@gmail.com> X-Mailer: git-send-email 2.17.1 To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use the ENOMEM constant instead of -1 for kzalloc failure checks in rtl_halmac.c Signed-off-by: Aymen Qader --- drivers/staging/rtlwifi/halmac/rtl_halmac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtlwifi/halmac/rtl_halmac.c b/drivers/staging/rtlwifi/halmac/rtl_halmac.c index f0c6fc8c6aca..7bfc9620479a 100644 --- a/drivers/staging/rtlwifi/halmac/rtl_halmac.c +++ b/drivers/staging/rtlwifi/halmac/rtl_halmac.c @@ -209,7 +209,7 @@ static int init_halmac_event_with_waittime(struct rtl_priv *rtlpriv, if (!rtlpriv->halmac.indicator[id].comp) { comp = kzalloc(sizeof(*comp), GFP_KERNEL); if (!comp) - return -1; + return -ENOMEM; } else { RT_TRACE(rtlpriv, COMP_HALMAC, DBG_LOUD, "%s: id(%d) sctx is not NULL!!\n", __func__, @@ -359,7 +359,7 @@ static int init_priv(struct rtl_halmac *halmac) size = sizeof(*indicator) * count; indicator = kzalloc(size, GFP_KERNEL); if (!indicator) - return -1; + return -ENOMEM; halmac->indicator = indicator; return 0; -- 2.17.1