Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <5BB035B4.3030201@huawei.com>
Date:   Sun, 30 Sep 2018 10:32:20 +0800
From:   zhong jiang <zhongjiang@huawei.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120428 Thunderbird/12.0.1
MIME-Version: 1.0
To:     Joe Perches <joe@perches.com>
CC:     <broonie@kernel.org>, <perex@perex.cz>, <tiwai@suse.com>,
        <lgirdwood@gmail.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: wm8731: Fix a unused function gcc warning
References: <1538271918-24033-1-git-send-email-zhongjiang@huawei.com> <0e30a0ab635f0348bcf582efe018e53334a276fe.camel@perches.com>
In-Reply-To: <0e30a0ab635f0348bcf582efe018e53334a276fe.camel@perches.com>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2018/9/30 10:17, Joe Perches wrote:
> On Sun, 2018-09-30 at 09:45 +0800, zhong jiang wrote:
>> Fix the following compile warning:
>>
>> sound/soc/codecs/wm8731.c:575:12: warning: 'wm8731_request_supplies' defined but not used [-Wunused-function]
>> sound/soc/codecs/wm8731.c:600:12: warning: 'wm8731_hw_init' defined but not used [-Wunused-function]
> []
>> diff --git a/sound/soc/codecs/wm8731.c b/sound/soc/codecs/wm8731.c
> []
>> @@ -36,12 +36,15 @@
>>  #include "wm8731.h"
>>  
>>  #define WM8731_NUM_SUPPLIES 4
>> +
>> +#if defined(CONFIG_I2C) || defined(CONFIG_SPI_MASTER)
>>  static const char *wm8731_supply_names[WM8731_NUM_SUPPLIES] = {
>>  	"AVDD",
>>  	"HPVDD",
>>  	"DCVDD",
>>  	"DBVDD",
>>  };
>> +#endif
>>  
>>  /* codec private data */
>>  struct wm8731_priv {
>> @@ -572,6 +575,7 @@ static int wm8731_startup(struct snd_pcm_substream *substream,
>>  	.symmetric_rates = 1,
>>  };
>>  
>> +#if defined(CONFIG_I2C) || defined(CONFIG_SPI_MASTER)
>>  static int wm8731_request_supplies(struct device *dev,
>>  		struct wm8731_priv *wm8731)
>>  {
>> @@ -627,6 +631,7 @@ static int wm8731_hw_init(struct device *dev, struct wm8731_priv *wm8731)
>>  
>>  	return ret;
>>  }
>> +#endif
> It would be better to move the declaration of
> wm8731_supply_ fnames into the second #if block so
> there would only be a single #if block.
>
Yep,  Thanks,  Will repost in v2.

Sincerely,
zhong jiang