Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2536286imm; Sat, 29 Sep 2018 22:39:53 -0700 (PDT) X-Google-Smtp-Source: ACcGV60veqZtwD20Ayly3QqdRBPvRJm6KePazIn9eYbVjU9nRFowXVkFpn1UpZpO8r50oxauzvfS X-Received: by 2002:a63:4f4f:: with SMTP id p15-v6mr5226792pgl.71.1538285993111; Sat, 29 Sep 2018 22:39:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538285993; cv=none; d=google.com; s=arc-20160816; b=h2Jg+lVkQIgpaADBAP5vyDa5in8d6OoF0J4Dl+BNyba0ybcPKsF5HsqnxfTAz1P0fP UChZOsY11ddzscTombI+q2dCFI3mcmehdH0PtfpsN3toAdw/O9KbgZaTk76gZqlIIVy5 u/090UWYrXn6RVomxKrCrTCw9+40HjbngjvJTjMCex8J19UK1eD1SnE61oF21+2mrKHS GMpVefaSywlP3Tf/2b8/CWhqxqgp8GJ2pcSyc2rRbXB1MaUN2Jkv+jOXoUK98y0jt/b6 MdFyRUiXlSJFFP08V/Q9JWEhCLtOxvqOtVsZjPf0w5bpeB686MJ5PKwr3PaCG4rTwwE4 yFDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=hYvwQOtDmcdfGmQBimO+FxNNr2vPU6zNjYKbUxh+J1s=; b=c7TqDKuYYXYZMnc+ld4wDtAnUntL0UTmFyksdCYGJmUvRo7ZBRVNItaUga0lSczazB 9ilv4wNepchs8WA9T7guCbmqO7Qi2LEFDn6S7L6DnVUH7ApV24l9jvytR61xNwtAwn3u TBuE/G+Gr1kXP6w2vMwSczjc5PnhGdWwdVLp3cMbnDGETJIEm+g3IxbkAg0VTa+U90Ag ak1zie75YhC53YNqqrhnjpKH9+JU8YgPANsWTWc/b27zpc55UTl49TanKowI3xRiMTQM jUTCcDEoHsDPf+YX7ex0diawedatsUOLzbmoCyf9bqCPxr7VRoBmsTm0vnQ/3ZTG2BjX 4PSA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w24-v6si9343235ply.370.2018.09.29.22.39.37; Sat, 29 Sep 2018 22:39:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727862AbeI3MLG (ORCPT + 99 others); Sun, 30 Sep 2018 08:11:06 -0400 Received: from mail.bootlin.com ([62.4.15.54]:36488 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727702AbeI3MLG (ORCPT ); Sun, 30 Sep 2018 08:11:06 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id 46DFE207B4; Sun, 30 Sep 2018 07:39:29 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT shortcircuit=ham autolearn=disabled version=3.4.0 Received: from bbrezillon (91-160-177-164.subs.proxad.net [91.160.177.164]) by mail.bootlin.com (Postfix) with ESMTPSA id CB0C420717; Sun, 30 Sep 2018 07:39:28 +0200 (CEST) Date: Sun, 30 Sep 2018 07:39:27 +0200 From: Boris Brezillon To: Lukasz Majewski , Fabio Estevam , prabhakar.kushwaha@nxp.com, han.xu@nxp.com Cc: Frieder Schrempf , Mark Rutland , linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, yogeshnarayan.gaur@nxp.com, richard@nod.at, Stefan Agner , Fabio Estevam , broonie@kernel.org, david.wolfe@nxp.com, computersforpeace@gmail.com, dwmw2@infradead.org, albert.aribaud@3adev.fr Subject: Re: [RFC/RFT PATCH v1 0/9] mtd: fsl: quadspi: Fixes for fsl-quadspi.c driver (vybrid HW) Message-ID: <20180930073927.001c16d2@bbrezillon> In-Reply-To: <20180929230240.1c8d844d@jawa> References: <20180926220739.620-1-lukma@denx.de> <20180929000359.34fe18ae@bbrezillon> <20180929230240.1c8d844d@jawa> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lukasz, On Sat, 29 Sep 2018 23:02:40 +0200 Lukasz Majewski wrote: > > Talking about that, can you try to port your fixes on top of Frieder's > > patchset? I'm pretty sure some bug fixes are irrelevant after the > > migration to spi-mem (patch 1, 3, 4, 5, 6, 7 and 9 should be dropped I > > think). > > The problem is that Frieder's patch is using IP command mode for > transfers smaller than AHB RX fifo size. > This according to the comment in the current driver is broken in HW for > Vybrid (so this is a regression). Why not fixing that in the new driver? > > I'm also wondering if other users of vf610 based boards experience > issues with QSPI? Are you sure the 4 I/O lines are wired on your design? Anyway, if it's a bug that only hurts vf610, you should mask quad modes in ->hwcaps (or patch fsl_qspi_supports_op() in the new driver), not change the SPI NOR definition. > > In my case, after running the UBI/UBIFS tests (on the original and > new driver without those "fixes") I cannot mount the volume after > creation as the header is wrongly read. I'm not denying this fact, I'm just saying, now that you've found where the issue comes from, you can also port the fix to the new driver. Regards, Boris