Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2647684imm; Sun, 30 Sep 2018 01:35:18 -0700 (PDT) X-Google-Smtp-Source: ACcGV60r1RYAMhEJREft0Qy5Vj+xOUmfXNa0YnYRAytMzFT6L519tEqEdAKbhOf58wS7+T0bNJkV X-Received: by 2002:a17:902:ac89:: with SMTP id h9-v6mr6334381plr.174.1538296518474; Sun, 30 Sep 2018 01:35:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538296518; cv=none; d=google.com; s=arc-20160816; b=JXnxgT9KhrjdkzGylgvqMZPmMbo+cNfDiC2oew9cYHwm5gXYotUYBZkuj7PqYUwKty 07oSjfMJcqh1piHibJbbw+gSoOYeJZQaMJEh0HWLQ6ZZnz+ArWI+ygPdHJMmvJtWrs5V nqcq5q1rAQZiqjbXpBaMs5Qhbgc81I1jp39jqPFcjVGQeDafXU2FkBRVRks3/JiY/n4/ o+mO2eFz3sXPn7pgvOap56u230XsZLCdyXtxtMd9ZpgKoBUy5aUS/DTVf+LO8ariqbD/ sv+t3/HX44dsgUkKLQIrYXvj/Dn2vaQ3YTge//j+dV9YotZCwO1qdbyOmL8kvII/hB7q wFmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:message-id:date:subject:cc:from :dkim-signature; bh=O03SNQopYVqWnmt6VQndAGbPdcYqY8a+hbNGWhQupxY=; b=jHYHeoeWcMf8VfDZYX6MqJzYdmgGB5pIs7YeqhyZZvxAzDvjX/2wM8f4VITEo0UVCn NgbX2mZS+ORiMshvEHJi5eLTE4Niea1AeFaRUBsT6YLeOuxNinFjAITp+Hm0z/96rnPh fb2ZHziFx2+ywKp2GGoPjzCOUdoo07t8qx2QqSP9q6hDLfg8OqyUuGzujiOMDEOJHapQ 0yfReiKk7PQFYSnnSlaRyxHL56uYpLUfK3fdKxskfI/X+OU+sRbhmZypbMgNpGOUIad4 oPUB/DwV1myaiphSL4Eu7rT4jow/IUfAM+UZxx+TpMfMvdzb9zbQsT6dbh29gbVZTefI qrcw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=iiMJxHD+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i5-v6si2961245pgg.559.2018.09.30.01.35.02; Sun, 30 Sep 2018 01:35:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=iiMJxHD+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727818AbeI3PG7 (ORCPT + 99 others); Sun, 30 Sep 2018 11:06:59 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:40459 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727742AbeI3PG7 (ORCPT ); Sun, 30 Sep 2018 11:06:59 -0400 Received: by mail-wr1-f67.google.com with SMTP id y8-v6so10506301wrh.7 for ; Sun, 30 Sep 2018 01:34:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=O03SNQopYVqWnmt6VQndAGbPdcYqY8a+hbNGWhQupxY=; b=iiMJxHD+BIyV0t+PD1q71KdAObmRoh+mDgpsCxlRdZibvqnuDbYzVDifWIDO8WDLwO beeQnvT32F8gvh0u/3Y4qAfXBaHYBP7JjqdMwXa4L0nucCTyiQVhW5Hf+u7573Nf0PL8 groAuarFBi05s++tz8+v21NcygGbA0MICP2i5v4rqNBimzIlF/geiP9Bft3dCmPbBvvl 47vfB6Y3VrJsL0Zsk29F1HZ1+2vqln+CqciIAgYwAU+hpyK3DqDlvkj21wG0V6nIHi0a iGvqo+Erd0+TdARNfVaoJFe5R52j/sElk3HEeJ5ZW7mKilXa7QEPqh0hXW5hi1eQp3bO FvQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=O03SNQopYVqWnmt6VQndAGbPdcYqY8a+hbNGWhQupxY=; b=dk9EznvG+251Cq7MLt0QSXyw5miKRzhIvFvSXBQ8YCW82A8WTmLPaHmhKGQQfZeakt pI+FUjkckKN9l/OVafq2VUA+lvw3azeoF8EJxftlwuWKKyJE5B8FzVCWWLn6Mksu6oJ2 5tdRIlT+SQLGDHWTXB2phtQ6IWNn8OcEznpPJHVtZUro3u0naDqVE2mZh4Z63tCweWUw jxAQ+Q2Wc+06B0b1AVgnxd3C+pNetTZZsmIUVpjyMuopJy0KkPEyF306fseHI4GALb7o DU7MMh7j+ih1HBilC1mCzQ5jW6DYxuY/OMMXwjNklSnzqWkm+o5NH5xb6A49OOyYFfkS TQzw== X-Gm-Message-State: ABuFfoh7ufKYR/XZ96V0VXw+AsPSHBQy2KZVah2fl/3HaM5/uVXJnwKl srZMwMd09PeyogI3/MjGedM= X-Received: by 2002:adf:9a62:: with SMTP id z89-v6mr3489301wrb.53.1538296493802; Sun, 30 Sep 2018 01:34:53 -0700 (PDT) Received: from localhost.co.uk ([2a01:388:3ce:110::1:4]) by smtp.gmail.com with ESMTPSA id a18sm3828950wrx.55.2018.09.30.01.34.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 30 Sep 2018 01:34:53 -0700 (PDT) From: Aymen Qader Cc: Wolfram Sang , Aymen Qader , Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] staging: ks7010: Remove unnecessary null check Date: Sun, 30 Sep 2018 09:34:21 +0100 Message-Id: <20180930083421.5967-1-qader.aymen@gmail.com> X-Mailer: git-send-email 2.17.1 To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove the unnecessary socket buffer null check in hostif_data_request. There is already an appropriate null check in the calling function: (ks_wlan_net.c) ks_wlan_start_xmit Signed-off-by: Aymen Qader --- drivers/staging/ks7010/ks_hostif.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c index 0e554e3359b5..ca030d3f609f 100644 --- a/drivers/staging/ks7010/ks_hostif.c +++ b/drivers/staging/ks7010/ks_hostif.c @@ -1023,8 +1023,8 @@ int hostif_data_request(struct ks_wlan_private *priv, struct sk_buff *skb) priv->wpa.mic_failure.stop) { if (netif_queue_stopped(priv->net_dev)) netif_wake_queue(priv->net_dev); - if (skb) - dev_kfree_skb(skb); + + dev_kfree_skb(skb); return 0; } -- 2.17.1