Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2680998imm; Sun, 30 Sep 2018 02:27:36 -0700 (PDT) X-Google-Smtp-Source: ACcGV62nTa/wJOAEfsFa47YGUKHD/L+SusAy5hKYBAr5NvqY8fdt7SXqgO8rMLJOdH5VDRHKGapL X-Received: by 2002:a17:902:b198:: with SMTP id s24-v6mr6429825plr.70.1538299656092; Sun, 30 Sep 2018 02:27:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538299656; cv=none; d=google.com; s=arc-20160816; b=z2Hj/YiI+qFMHT2AEE7PA5urySFeEW7nm/oFkbgvxLJSI+EVo9FIhUqJvNhObFv7OD 24YFS5cMgQ0uVGAe0UGSt864+ZjNVlu48+ytZWV1Xa03aASShIYCeOqYR/WsdcDiQxni 4+ZvUM8Czz6jNWAyNAjxW4YenRXDj80X+0LExyjaWIuNnZR04NnqpFJxrfP5NmXZHg1Q okfhiluPBNrQf/BxczBsoPC3Z7pTEVpF53dsu82rq54U4C0CgaNNVOcsFXcJPPGdKufJ ewWF8VQ63DNmX1XtoXOJPXlrjL+a0OYDlV2ry6Ab2BYBMeFJyJqIdGOWxmRzTXn9I6JJ PQgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=wULOfdtgg+vCpI/bLFxW2N8RcnZgHI0BEVRbm2J2YWQ=; b=YdhxhgQXkcRGcrBG313ddcJTl+YQEwh7HZ0a5B4ZLsxRGM1uEkvCLBcJ4rfs6q1K2f EU+RfPO4xja5NvbJsncvSDkJGJJ6OAhW0E6ZBdPtItnkowAYZWJsIl8wMx4/LqnZbipd PieQoWz0/G2J+feggrUxbMxR7klz1tT6tfS92GKglSxaJcIMQLi3b0reg1fODYP925Pw TrwS6+V3n/HEF+HeBejUi5xeDnZdiXLGOzyuIqasFCma4BOlsEC7KrEnoL2vuPZFg0RQ VTmBVGXVP3tkIb6LIWbN46xo74VHXZJWmCP/CuUrR9h/SCvdUZoUT57tYJzBWX7QcbPl zAsA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o12-v6si5609684pfh.9.2018.09.30.02.27.20; Sun, 30 Sep 2018 02:27:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728055AbeI3P5n (ORCPT + 99 others); Sun, 30 Sep 2018 11:57:43 -0400 Received: from inva020.nxp.com ([92.121.34.13]:33512 "EHLO inva020.nxp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728001AbeI3P5m (ORCPT ); Sun, 30 Sep 2018 11:57:42 -0400 Received: from inva020.nxp.com (localhost [127.0.0.1]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 77D0C1A013D; Sun, 30 Sep 2018 11:25:28 +0200 (CEST) Received: from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com [165.114.16.14]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 0BE0A1A0003; Sun, 30 Sep 2018 11:25:25 +0200 (CEST) Received: from mega.ap.freescale.net (mega.ap.freescale.net [10.192.208.232]) by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 6F3F9402F2; Sun, 30 Sep 2018 17:25:20 +0800 (SGT) From: Chuanhua Han To: broonie@kernel.org Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, boris.brezillon@bootlin.com, eha@deif.com, Chuanhua Han Subject: [PATCH v2 2/4] spi: spi-fsl-dspi: Fix delete the processing of undefined bitmask for rxdata Date: Sun, 30 Sep 2018 17:25:33 +0800 Message-Id: <20180930092535.24544-2-chuanhua.han@nxp.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180930092535.24544-1-chuanhua.han@nxp.com> References: <20180930092535.24544-1-chuanhua.han@nxp.com> X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch fixes the problem of rxdata being equal to 0 during the XSPI mode transfer of the dspi controller. In XSPI mode, If it is not deleted, the value of rxdata will be equal to 0, and the data received will not be received correctly, causing the receiving transfer of the spi to fail. Signed-off-by: Chuanhua Han --- Changes in v2: -The original patch is divided into multiple patches(the original patch theme is "spi: spi-fsl-dspi: Fix support for XSPI transport mode"),one of which is segmented. drivers/spi/spi-fsl-dspi.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/spi/spi-fsl-dspi.c b/drivers/spi/spi-fsl-dspi.c index 3082e72e4f6c..4dc1064bf408 100644 --- a/drivers/spi/spi-fsl-dspi.c +++ b/drivers/spi/spi-fsl-dspi.c @@ -243,9 +243,6 @@ static void dspi_push_rx(struct fsl_dspi *dspi, u32 rxdata) if (!dspi->rx) return; - /* Mask of undefined bits */ - rxdata &= (1 << dspi->bits_per_word) - 1; - if (dspi->bytes_per_word == 1) *(u8 *)dspi->rx = rxdata; else if (dspi->bytes_per_word == 2) -- 2.17.1