Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 1 Oct 2018 00:17:51 +0200
From:   Daan Wendelen <daanwendelen@gmail.com>
To:     "Alex Xu (Hello71)" <alex_y_xu@yahoo.ca>
Cc:     netdev@vger.kernel.org, hkallweit1@gmail.com, nic_swsd@realtek.com,
        davem@davemloft.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2] r8169: always autoneg on resume
Message-ID: <20180930221751.rd7wva3zolephj6q@scappy>
References: <1538319728.z22jaatdgh.astroid@alex-desktop.none>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1538319728.z22jaatdgh.astroid@alex-desktop.none>
User-Agent: NeoMutt/20171215
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Alex,

I randomly opened your patch even though I have absolutely no idea what this patch is about, but I
found a mistake in one of the comments:

On Sun, Sep 30, 2018 at 11:06:39AM -0400, Alex Xu (Hello71) wrote:
> This affects at least versions 25 and 33, so assume all cards are broken
                     ...
>  	 * 1GBit link after resuming from S3. For whatever reason the PHY on
> -	 * this chip doesn't properly start a renegotiation when soft-reset.
> +	 * these chips doesn't properly start a renegotiation when soft-reset.
                       ~~~~~~~ 
I believe it should be "these chips don't"

With kind regards,
Daan