Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
To:     Daan Wendelen <daanwendelen@gmail.com>
From:   Alex Xu <alex_y_xu@yahoo.ca>
In-Reply-To: <20180930221751.rd7wva3zolephj6q@scappy>
Cc:     netdev@vger.kernel.org, hkallweit1@gmail.com, nic_swsd@realtek.com,
        davem@davemloft.net, linux-kernel@vger.kernel.org
References: <1538319728.z22jaatdgh.astroid@alex-desktop.none>
 <20180930221751.rd7wva3zolephj6q@scappy>
Message-ID: <153834665886.421.6376790866713055481@pink.alxu.ca>
User-Agent: alot/0.7
Subject: Re: [PATCH net v2] r8169: always autoneg on resume
Date:   Sun, 30 Sep 2018 22:30:58 +0000
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Daan Wendelen (2018-09-30 22:17:51)
> Hi Alex,
> =

> I randomly opened your patch even though I have absolutely no idea what t=
his patch is about, but I
> found a mistake in one of the comments:
> =

> On Sun, Sep 30, 2018 at 11:06:39AM -0400, Alex Xu (Hello71) wrote:
> > This affects at least versions 25 and 33, so assume all cards are broken
>                      ...
> >        * 1GBit link after resuming from S3. For whatever reason the PHY=
 on
> > -      * this chip doesn't properly start a renegotiation when soft-res=
et.
> > +      * these chips doesn't properly start a renegotiation when soft-r=
eset.
>                        ~~~~~~~ =

> I believe it should be "these chips don't"
> =

> With kind regards,
> Daan

The grammar is correct as is. The subject of the sentence is "the PHY",
which is singular. However, I think it should be "the PHYs" instead,
assuming that they are different.