Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 1 Oct 2018 11:22:46 +1000
From:   Stephen Rothwell <sfr@canb.auug.org.au>
To:     Sasha Levin <Alexander.Levin@microsoft.com>
Cc:     "stable@vger.kernel.org" <stable@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Steven French <Steven.French@microsoft.com>
Subject: Re: [PATCH AUTOSEL 4.18 39/65] fs/cifs: suppress a string overflow
 warning
Message-ID: <20181001112246.4dcbc4fd@canb.auug.org.au>
In-Reply-To: <20181001003754.146961-39-alexander.levin@microsoft.com>
References: <20181001003754.146961-1-alexander.levin@microsoft.com>
        <20181001003754.146961-39-alexander.levin@microsoft.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 boundary="Sig_/FB.wSKEEne+ng3sjN0gw3au"; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--Sig_/FB.wSKEEne+ng3sjN0gw3au
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi Sasha,

On Mon, 1 Oct 2018 00:38:27 +0000 Sasha Levin <Alexander.Levin@microsoft.co=
m> wrote:
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
>=20
> [ Upstream commit bcfb84a996f6fa90b5e6e2954b2accb7a4711097 ]
>=20
> A powerpc build of cifs with gcc v8.2.0 produces this warning:
>=20
> fs/cifs/cifssmb.c: In function =E2=80=98CIFSSMBNegotiate=E2=80=99:
> fs/cifs/cifssmb.c:605:3: warning: =E2=80=98strncpy=E2=80=99 writing 16 by=
tes into a region of size 1 overflows the destination [-Wstringop-overflow=
=3D]
>    strncpy(pSMB->DialectsArray+count, protocols[i].name, 16);
>    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>=20
> Since we are already doing a strlen() on the source, change the strncpy
> to a memcpy().
>=20
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Steve French <stfrench@microsoft.com>
> Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>

Just wondering if this should be included as it only fixes a build
warning, there is no actual bug.  Same for the 4.9 and 4.14 versions.

--=20
Cheers,
Stephen Rothwell

--Sig_/FB.wSKEEne+ng3sjN0gw3au
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAluxduYACgkQAVBC80lX
0Gx2Vgf/Uj49VQIpbqz6RklI7JG/+T6uaGbCoiHF5pM56P7nSI6sfo5uNUscI0pc
nmmHrkiyR8jtps79hcyaaqjsQU5hPzxD108ruKMJaOQmDeyKTmsgqPUS8hcaa1vd
RNvrktZ/76h/TJzn1Cb9VA8B/ylUIIKq8oS5M3cUc698vUhuZruCUTiIiHlFFB8N
DSPpaB+KJbsQZUoBIXQ/J1WKGYJ0tN16xutpsaYXgLXZanhudBDtoQRh6lpvxsnB
+nu/P7M96Rk4zs5mXhQFEkNVR8gQlDUf5E0zOsA0D+shR6XyetNlUwIvNdml3kjs
bhagg+KCUlO9h4DzODmW02mzli4Ryg==
=KRsJ
-----END PGP SIGNATURE-----

--Sig_/FB.wSKEEne+ng3sjN0gw3au--