Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 10/11] ALSA: hda/ca0132 - Add ZxR 600 ohm gain control
To:     Connor McAdams <conmanx360@gmail.com>
Cc:     Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        Alastair Bridgewater <alastair.bridgewater@gmail.com>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
References: <1538276607-30234-1-git-send-email-conmanx360@gmail.com>
 <1538276607-30234-11-git-send-email-conmanx360@gmail.com>
From:   Takashi Sakamoto <o-takashi@sakamocchi.jp>
Message-ID: <e313237f-1f99-bf87-ebb9-8dffb7a96e46@sakamocchi.jp>
Date:   Mon, 1 Oct 2018 11:22:57 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.7.0
MIME-Version: 1.0
In-Reply-To: <1538276607-30234-11-git-send-email-conmanx360@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

On Sep 30 2018 12:03, Connor McAdams wrote:
> This patch adds a control for 600 ohm gain on the Sound Blaster ZxR.
> 
> Signed-off-by: Connor McAdams <conmanx360@gmail.com>
> ---
>   sound/pci/hda/patch_ca0132.c | 44 ++++++++++++++++++++++++++++++++++++++++++--
>   1 file changed, 42 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/pci/hda/patch_ca0132.c b/sound/pci/hda/patch_ca0132.c
> index f0781e4..90e6a96 100644
> --- a/sound/pci/hda/patch_ca0132.c
> +++ b/sound/pci/hda/patch_ca0132.c
> ..
> @@ -6415,6 +6452,9 @@ static int ca0132_build_controls(struct hda_codec *codec)
>   		ae5_add_headphone_gain_enum(codec);
>   		ae5_add_sound_filter_enum(codec);
>   	}
> +
> +	if (spec->quirk == QUIRK_ZXR)
> +		zxr_add_headphone_gain_switch(codec);
>   #ifdef ENABLE_TUNING_CONTROLS
>   	add_tuning_ctls(codec);
>   #endif

Though error code can be returned in a call of snd_hda_ctl_add(), it's 
not handled correctly in 'ca0132_build_controls()'. At least, return
code in calls of below functions is better to be checked.

  - add_voicefx()
  - add_ca0132_alt_eq_presets()
  - ca0132_alt_add_svm_enum()
  - ca0132_alt_add_output_enum
  - ca0132_alt_add_input_enum
  - ca0132_alt_add_mic_boost_enum
  - ae5_add_headphone_gain_enum
  - ae5_add_sound_filter_enum
  - zxr_add_headphone_gain_switch

This is not a strong request and you can work for it after merging this
patchset. We have two weeks more till next merge window.


Regards

Takashi Sakamoto