Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp3689244imm; Mon, 1 Oct 2018 02:52:54 -0700 (PDT) X-Google-Smtp-Source: ACcGV60xdYP7IOVVndNv/QU92sjP/295aCydW7A8eJ0FmG5HZmOyi4IZZGb+nfDQAKewZBi3TTWA X-Received: by 2002:a63:4e11:: with SMTP id c17-v6mr9475947pgb.6.1538387574184; Mon, 01 Oct 2018 02:52:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538387574; cv=none; d=google.com; s=arc-20160816; b=FXjzmevmNXIY8sf8JnLcnnuJB+1y0LILU5UMKHJXRB28v0lqWPx4TTmWdDHyOSnKkU gWqPBS0iQsUzfR6hh9DT3wRpc3DgPqjvA3FnP/qsdOCUwd4dTddAjIzwG0rJ1pM/ZU9q /fFl3ev7z/WWncr1pJQXwmIbrprYtNHG3BnV0JOKBy7if3VM8/rBROJIFokejhMqQMwr ZmqLlOWj24cNA4X7a/g6lI2oDJO6l3HXpBHfahSwNgkFd+jXtK7zw2y3XMYd12fB6pm5 rashdDnkdJveSRc7z+rZBFxoWBkLKroXqatN9TkLIc4n64um7DjXMSeA8apLB+5v9XNb o+9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=ZltC4BgGNykYL6ehmAXhpCYXTxjo/xz5TWGDHnZrxCw=; b=CAbptA7Sbe3VBHFAHFDJ4nGRWmzaNFV6D4sJ+5qHr01FcD8qMMTuRAAeu5e16e+qAs 8Rg03/vLJMTFR/khlX9ECHPECoulMVt2sQy0ZceqiJTupAO8RM4NN7VVfNOolRYO76et 1rDqDSlVWa3+O20EC79Oidm4iq22UfEf1CBKk0ohWtsngGsbVte2K2swA2XA+s6phVMB MACh/BMC4GVLXm7mv0lYI/OlBi27OTNZ+x5x3smPkWhveFsq1w6uC8sRA/048epEh5o6 CUPGQ0a1AIz24/MVfrbPZW4tFIvyfY4lZO91B9U0f9Qv1956t5rsBgmk50iJtahcAQtB Rz8A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=cvRHQ1H4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k24-v6si11645027pgj.28.2018.10.01.02.52.39; Mon, 01 Oct 2018 02:52:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=cvRHQ1H4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729150AbeJAQ3Y (ORCPT + 99 others); Mon, 1 Oct 2018 12:29:24 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:48800 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729045AbeJAQ3Y (ORCPT ); Mon, 1 Oct 2018 12:29:24 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w919nAJ4124932; Mon, 1 Oct 2018 09:52:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=ZltC4BgGNykYL6ehmAXhpCYXTxjo/xz5TWGDHnZrxCw=; b=cvRHQ1H4Dy4TCpNR8OLyErWWWeLdPtmQp1QcnAOMU+6WEuPV0O/Kfy3eNBu0EHheNVCe NFj2ErjnmvS5PtD06BlQ2nKhKASNbUuxCDQDE4S5CBRSsQXsmoot5ZOpAPPOEV1ox1oE tEs8o0RrjccGW2vLt9ZAybE1apmW+6hWYziU51fp+eQ0BwnEKtn2Z7YMQQwdRJMluyXO cxLNzMtmRQOzhO9IdvbSnSQXbNEN4Q+ZnWbM0mssrOobem0MN64RSJsFsmbff7FiY4K7 1c+nLkusBTkyJ2B+iQCIJlXtNQfdJlpf1ojig/qM/iSrXFgqKndLWy4P6K+JvZOwnrDs FQ== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp2120.oracle.com with ESMTP id 2mt21qnupv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 01 Oct 2018 09:52:23 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w919qMiH001497 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 1 Oct 2018 09:52:22 GMT Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w919qLRh012303; Mon, 1 Oct 2018 09:52:21 GMT Received: from mwanda (/197.232.248.111) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 01 Oct 2018 02:52:21 -0700 Date: Mon, 1 Oct 2018 12:52:14 +0300 From: Dan Carpenter To: Andrey Abramov Cc: mchehab@kernel.org, gregkh@linuxfoundation.org, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: media: replaced deprecated probe method Message-ID: <20181001095214.pjp7cshbi3nxq6w5@mwanda> References: <20181001094229.9148-1-st5pub@yandex.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181001094229.9148-1-st5pub@yandex.ru> User-Agent: NeoMutt/20170609 (1.8.3) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9032 signatures=668707 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=18 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=701 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1810010101 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 01, 2018 at 12:42:29PM +0300, Andrey Abramov wrote: > Replaced i2c_driver::probe with i2c_driver::probe_new, > because documentation says that probe method is "soon to be deprecated". > And fixed problems of the previous attempt. I'm sorry to complain again... Please, don't reference the "previous attempt" in the commit message. The previous attempt is gone so no one will remember what you are talking about after tomorrow. This is how you resend a patch. Change the subject to: Subject: [PATCH v3] Staging: media: replace deprecated probe method > > Signed-off-by: Andrey Abramov > --- > drivers/staging/media/bcm2048/radio-bcm2048.c | 5 ++--- Then right after the --- line put: v3: fix commit message That part of the commit message will be removed when we apply the patch. regards, dan carpenter