Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp3753401imm; Mon, 1 Oct 2018 04:03:39 -0700 (PDT) X-Google-Smtp-Source: ACcGV638lXtPvADK/hCZmQkLYiN2eYtKKBm5XNsdUy8HGmieGVx3KRAqVA4yXq8Dr7vsk81s6mh1 X-Received: by 2002:a62:1bce:: with SMTP id b197-v6mr10961656pfb.102.1538391819088; Mon, 01 Oct 2018 04:03:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538391819; cv=none; d=google.com; s=arc-20160816; b=VoK4E1TYASUadtJsXrOQkkTinkv/pXdybtU+218tl7nBRbTe+yee1d4qvBaBHxEXSn kApWMuHqQLYQyAdX60kOf8UIANzCG1es8d+Oz2RMK833LP9PlKrFOvCDH34p9Pyb+BxG YVEUDnOHiumMbQUXnnI2LYAUdHmN935DpfELYGhP4xV0FjRUmt6l8cctpFxeghqpe0wQ +/DHaEf/fJxViu1kI3Ir54HXipQPHpqdtY8xN87dGra8Mibtvam6ZbCTaBJXgQpgkXYz 4ME36tejpqe0AUlNUHf+iOZfceY3pUOyR6ckl3waWnyyiT5MEFX31u/rYHiaimeHwd9E 9ScQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=XvAWAh404LNfz4GXcjZAnM4XX/bdpbqGYOZLs2flxtc=; b=HwyIYh0TrU64HnMezkdtTq83lPuKa3jAKM5nl06SH67/WXVafSm29KUT9FuO2PV9pA 61t97/w3MNMwz+YixQZPX74Gj0C7hGlrRQflp1FOvUqPqc7U5c6N4BusAkxzrBWaEASk J2TxaRFvvTwBbUy37HLEgPeCfBONT9zD1otkHzaZcuXFoKRr1MFnY1IO3/oF2ubbARN+ 7kNXop3UaRmoMzt/czaO0SGsux+qgIN8SsJFTUZFTkwVbs0oz1BeVaPre1pixGau75Kt g/1tPPNoSoeYXXMIdgmEbtfdxFvy8k1tR+DJCdfdtw/vwEHZc45wiNnzKEvW7GAnGoXD YZ+w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x15-v6si7961059pgf.307.2018.10.01.04.03.24; Mon, 01 Oct 2018 04:03:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729155AbeJARjN (ORCPT + 99 others); Mon, 1 Oct 2018 13:39:13 -0400 Received: from isilmar-4.linta.de ([136.243.71.142]:33034 "EHLO isilmar-4.linta.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729026AbeJARjN (ORCPT ); Mon, 1 Oct 2018 13:39:13 -0400 Received: from light.dominikbrodowski.net (isilmar.linta [10.0.0.1]) by isilmar-4.linta.de (Postfix) with ESMTPS id 4010B2008DB; Mon, 1 Oct 2018 10:55:54 +0000 (UTC) Received: by light.dominikbrodowski.net (Postfix, from userid 1000) id D99A220650; Mon, 1 Oct 2018 11:38:53 +0200 (CEST) Date: Mon, 1 Oct 2018 11:38:53 +0200 From: Dominik Brodowski To: Jia-Ju Bai Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] pcmcia: pcmcia_resource: Replace mdelay() with msleep() Message-ID: <20181001093853.GC7482@light.dominikbrodowski.net> References: <20180730134256.8901-1-baijiaju1990@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180730134256.8901-1-baijiaju1990@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 30, 2018 at 09:42:56PM +0800, Jia-Ju Bai wrote: > pcmcia_fixup_iowidth() and pcmcia_enable_device() are > never called in atomic context. > They call mdelay() to busily wait, which is not necessary. > mdelay() can be replaced with msleep(). > > This is found by a static analysis tool named DCNS written by myself. > > Signed-off-by: Jia-Ju Bai Applied to pcmcia-next, thanks. Dominik