Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 8689A60265
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] ipw2x00: Remove unnecessary parentheses
From:   Kalle Valo <kvalo@codeaurora.org>
In-Reply-To: <20180920204548.2405-1-natechancellor@gmail.com>
References: <20180920204548.2405-1-natechancellor@gmail.com>
To:     Nathan Chancellor <natechancellor@gmail.com>
Cc:     Stanislav Yakovlev <stas.yakovlev@gmail.com>,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Nathan Chancellor <natechancellor@gmail.com>
User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12
Message-Id: <20181001153047.4102060B7A@smtp.codeaurora.org>
Date:   Mon,  1 Oct 2018 15:30:47 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Nathan Chancellor <natechancellor@gmail.com> wrote:

> Clang warns when multiple pairs of parentheses are used for a single
> conditional statement.
> 
> drivers/net/wireless/intel/ipw2x00/ipw2200.c:5655:28: warning: equality
> comparison with extraneous parentheses [-Wparentheses-equality]
>                 if ((priv->ieee->iw_mode == IW_MODE_ADHOC)) {
>                      ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
> drivers/net/wireless/intel/ipw2x00/ipw2200.c:5655:28: note: remove
> extraneous parentheses around the comparison to silence this warning
>                 if ((priv->ieee->iw_mode == IW_MODE_ADHOC)) {
>                     ~                    ^               ~
> drivers/net/wireless/intel/ipw2x00/ipw2200.c:5655:28: note: use '=' to
> turn this equality comparison into an assignment
>                 if ((priv->ieee->iw_mode == IW_MODE_ADHOC)) {
>                                          ^~
>                                          =
> 1 warning generated.
> 
> Link: https://github.com/ClangBuiltLinux/linux/issues/134
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>

Patch applied to wireless-drivers-next.git, thanks.

c15ace868dd1 ipw2x00: Remove unnecessary parentheses

-- 
https://patchwork.kernel.org/patch/10608735/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches