Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
To:     Niklas Cassel <niklas.cassel@linaro.org>
From:   Stephen Boyd <swboyd@chromium.org>
In-Reply-To: <20180912103431.GA27204@centauri.ideon.se>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
        linux-arm-msm@vger.kernel.org,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Doug Anderson <dianders@chromium.org>
References: <20180816200648.90458-1-swboyd@chromium.org>
 <20180912103431.GA27204@centauri.ideon.se>
Message-ID: <153841961783.119890.13486677118739554119@swboyd.mtv.corp.google.com>
User-Agent: alot/0.7
Subject: Re: [PATCH v3 0/3] pinctrl: msm interrupt and muxing fixes
Date:   Mon, 01 Oct 2018 11:46:57 -0700
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Niklas Cassel (2018-09-12 03:34:31)
> Hello Stephen,
> =

> I'm getting this warning on dragonboard 820c (msm8996) when booting linux=
-next:
> =

> [    3.211575] WARNING: CPU: 1 PID: 1 at drivers/pinctrl/qcom/pinctrl-msm=
.c:164 msm_pinmux_set_mux+0xc8/0x150
> [    3.212127] l28: ramp_delay not set

Thanks for testing. I think the problem is I messed up the function 0
and enum 0. Can you try this patch?

--8<---
diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinc=
trl-msm.c
index 1684b2da09d5..b925b8feac95 100644
--- a/drivers/pinctrl/qcom/pinctrl-msm.c
+++ b/drivers/pinctrl/qcom/pinctrl-msm.c
@@ -188,7 +188,7 @@ static int msm_pinmux_request_gpio(struct pinctrl_dev *=
pctldev,
 		return 0;
 =

 	/* For now assume function 0 is GPIO because it always is */
-	return msm_pinmux_set_mux(pctldev, 0, offset);
+	return msm_pinmux_set_mux(pctldev, g->funcs[0], offset);
 }
 =

 static const struct pinmux_ops msm_pinmux_ops =3D {