Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp666580imm; Mon, 1 Oct 2018 16:46:56 -0700 (PDT) X-Google-Smtp-Source: ACcGV63FXLQkjXb38Qg2wNd41rmsFhieQKBp1XFikiDtS8irwnXrfYjw+5nutK9LokRWnYAeRoC+ X-Received: by 2002:a62:2646:: with SMTP id m67-v6mr13751980pfm.254.1538437616306; Mon, 01 Oct 2018 16:46:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538437616; cv=none; d=google.com; s=arc-20160816; b=i95ccJps0MpsMcaoNoqhEyKt/jcds5SSkuc7M2vxQlTVoOspS0Hn1LOqBBsfdvs4he zhnLRv+cmjTZCQGf/EiARkTPll2WErBpf23aGxOZ4qI0krA07f6TcJpk4oy8psrBPi4A BKYZNfF4qb7nSDaRl5DUzQ/12js7Be2yHWx0RNHfYFQ7Hni8oOBmsKQ8qRbkXvBigPA1 7DR7iQy2hq5ALgRyRVcDfHjfKE+DPyKiCmjBi6yxJhFzPSnOELYS+uxNQ8mthjaYn7iv nOonKLqEQ+8J69JwDA4xd4wvvtK6hnjK9oO3FBxu9DOqOt3IaC+r9H5pHl2GAVF0l+lx WVBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=wQs1EFbtxHxIntv748mTmlY+O0Ss1Q/mMNGW1Zt3hgc=; b=IP104dCO5pYpnQbQPp1+hO6H19NxrV2KATCqCXGN8K++cF9l9xyhMZjuiIUHQ30/Qe OrUGVJU32UfxX0v5yG/zKaYD4E9NU6mHqZ4Yqff8QqwRToUQ7xeO+J3Vr6D56Nk5xa7v d0kpnHgDbJoe6DuYnsr0JX8YsBpOf1d8CRlfY5VwwsXOSC5+VMdaxRmIhksiTp5eAP1F QBGwX5m9lj2jjJhX2cKHg6TzIcf3UYgkLPueTbxBTmIu/Qe/Op3WDlS7ShKBaPPRVD6O 0czsg+4yFQvC7FnYcL8JHE/3zQiihtPTKwoAgx3V7K/2NPJt5qkJQEXRjEo7xP6Rr0oP 13cg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c11-v6si7186335pgj.409.2018.10.01.16.46.41; Mon, 01 Oct 2018 16:46:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726502AbeJBG0u (ORCPT + 99 others); Tue, 2 Oct 2018 02:26:50 -0400 Received: from smtprelay0249.hostedemail.com ([216.40.44.249]:37806 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725936AbeJBG0u (ORCPT ); Tue, 2 Oct 2018 02:26:50 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay04.hostedemail.com (Postfix) with ESMTP id A958D180A812A; Mon, 1 Oct 2018 23:46:33 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:69:355:379:599:960:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3673:3865:3866:3867:3868:3870:4321:4605:5007:10004:10400:10848:11026:11232:11658:11914:12043:12050:12296:12438:12740:12760:12895:13069:13311:13357:13439:14096:14097:14659:14721:21080:21433:21451:21627:30029:30054:30091,0,RBL:47.151.153.53:@perches.com:.lbl8.mailshell.net-62.14.0.100 64.201.201.201,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:29,LUA_SUMMARY:none X-HE-Tag: hands55_562f32e6ad64b X-Filterd-Recvd-Size: 2399 Received: from XPS-9350.home (unknown [47.151.153.53]) (Authenticated sender: joe@perches.com) by omf18.hostedemail.com (Postfix) with ESMTPA; Mon, 1 Oct 2018 23:46:32 +0000 (UTC) Message-ID: <8520d397189a1c95df203c0be2b487675b170f31.camel@perches.com> Subject: Re: [PATCH 0/7] Neaten logging uses From: Joe Perches To: MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org Cc: Sathya Prakash , Chaitra P B , Suganath Prabu Subramani , "James E.J. Bottomley" , "Martin K. Petersen" , linux-kernel@vger.kernel.org Date: Mon, 01 Oct 2018 16:46:31 -0700 In-Reply-To: References: Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.30.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2018-09-17 at 08:01 -0700, Joe Perches wrote: > Several defects exist in the logging uses > > o Missing KERN_ > o Unnecessary KERN_ uses with panic > o Mismatched MPT3SAS_FMT and %s: with name and __func__ > > Correct these defects and perhaps add some clarity to the logging. Submitted 2 weeks ago now without comment. ping... > Joe Perches (7): > mpt3sas: Add ioc_ logging macros > mpt3sas: Convert uses of pr_ with MPT3SAS_FMT to ioc_ > mpt3sas: Convert mlsleading uses of pr_ with MPT3SAS_FMT > mpt3sas: Convert logging uses with MPT3SAS_FMT and reply_q_name to %s: > mpt3sas: Remove KERN_WARNING from panic uses > mpt3sas: Convert logging uses with MPT3SAS_FMT without logging levels > mpt3sas: Remove unused macro MPT3SAS_FMT > > drivers/scsi/mpt3sas/mpt3sas_base.c | 1116 +++++++++----------- > drivers/scsi/mpt3sas/mpt3sas_base.h | 9 +- > drivers/scsi/mpt3sas/mpt3sas_config.c | 89 +- > drivers/scsi/mpt3sas/mpt3sas_ctl.c | 493 ++++----- > drivers/scsi/mpt3sas/mpt3sas_scsih.c | 1487 ++++++++++++--------------- > drivers/scsi/mpt3sas/mpt3sas_transport.c | 337 +++--- > drivers/scsi/mpt3sas/mpt3sas_trigger_diag.c | 101 +- > drivers/scsi/mpt3sas/mpt3sas_warpdrive.c | 70 +- > 8 files changed, 1618 insertions(+), 2084 deletions(-) >